Skip to content

[DRAFT] Migrated compute_instance_helpers.go.tmpl to use transport_tpg.SendRequest - new APIs - 2#17169

Draft
nsamartsev wants to merge 3 commits intoGoogleCloudPlatform:mainfrom
nsamartsev:compute-instance-helpers-migration-expand-2
Draft

[DRAFT] Migrated compute_instance_helpers.go.tmpl to use transport_tpg.SendRequest - new APIs - 2#17169
nsamartsev wants to merge 3 commits intoGoogleCloudPlatform:mainfrom
nsamartsev:compute-instance-helpers-migration-expand-2

Conversation

@nsamartsev
Copy link
Copy Markdown
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: migrated `compute_instance_helpers` resource to use direct HTTP rather than a client library

@nsamartsev nsamartsev changed the title Migrated compute_instance_helpers.go.tmpl to use transport_tpg.SendRequest Migrated compute_instance_helpers.go.tmpl to use transport_tpg.SendRequest - new APIs Apr 17, 2026
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 559 insertions(+))
google-beta provider: Diff ( 2 files changed, 645 insertions(+))
terraform-google-conversion: Diff ( 2 files changed, 934 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 1413
Passed tests: 1322
Skipped tests: 91
Affected tests: 0

Click here to see the affected service packages
  • compute

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 536 insertions(+))
google-beta provider: Diff ( 2 files changed, 622 insertions(+))
terraform-google-conversion: Diff ( 2 files changed, 934 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 1413
Passed tests: 1321
Skipped tests: 91
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRouterPeer_UpdateMd5AuthenticationKey

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeRouterPeer_UpdateMd5AuthenticationKey [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@nsamartsev nsamartsev changed the title Migrated compute_instance_helpers.go.tmpl to use transport_tpg.SendRequest - new APIs Migrated compute_instance_helpers.go.tmpl to use transport_tpg.SendRequest - new APIs - 2 Apr 17, 2026
@nsamartsev nsamartsev changed the title Migrated compute_instance_helpers.go.tmpl to use transport_tpg.SendRequest - new APIs - 2 [DRAFT] Migrated compute_instance_helpers.go.tmpl to use transport_tpg.SendRequest - new APIs - 2 Apr 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants