Adds params.resource_manager_tags to `google_compute_region_commitm…#17163
Open
GitOleksandrBokov wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Open
Conversation
modular-magician
added
the
awaiting-approval
…ent` so IAM resource manager tags can be bound at commitment creation. The field is input-only and ForceNew, matching the existing pattern on `google_compute_network` (GoogleCloudPlatform#14119) and other Compute resources. The acceptance test has no `CheckDestroy` because `RegionCommitment` is `exclude_delete: true`; recording it creates a real, non-deletable multi-year commitment, so it should be recorded once on a sacrificial project and replayed in CI. ```release-note:enhancement compute: added `params.resource_manager_tags` field to `google_compute_region_commitment` resource ```
GitOleksandrBokov
force-pushed
the
add-region-commitment-resource-manager-tags
branch
from
13b9f0b to
c9bdd93
Compare
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
params.resource_manager_tagstogoogle_compute_region_commitmentso IAM resource manager tags can be bound at commitment creation. The field is input-only and ForceNew, matching the existing pattern ongoogle_compute_network(#14119) and other Compute resources.The acceptance test has no
CheckDestroybecauseRegionCommitmentisexclude_delete: true; recording it creates a real, non-deletable multi-year commitment, so it should be recorded once on a sacrificial project and replayed in CI.