chore: Update Golang version to 1.26.1 for v2.5.0 release

.github/workflows/ci.yml

@@ -17,7 +17,7 @@ jobs:
     - name: Set up Go
       uses: actions/setup-go@v5
       with:
-        go-version: "1.23"
+        go-version: "1.26"
     - name: Install goimports
       run: go install golang.org/x/tools/cmd/goimports
     - name: Formatting diff
@@ -26,7 +26,7 @@ jobs:
   linux-tests:
     strategy:
       matrix:
-        go: [ 1.23.x ]
+        go: [ 1.26.x ]
     runs-on: ubuntu-latest
     timeout-minutes: 15
 
@@ -64,12 +64,13 @@ jobs:
     - name: Setup Go
       uses: actions/setup-go@v4
       with:
-        go-version: "1.23"
+        go-version: "1.26"
     - name: checkout code
       uses: actions/checkout@v4
     - name: golangci-lint
-      uses: golangci/golangci-lint-action@032fa5c5e48499f06cf9d32c02149bfac1284239
+      uses: golangci/golangci-lint-action@v6
       with:
+        version: latest
         args: -E=goimports --timeout 2m0s
         only-new-issues: true
 

.github/workflows/flake-detector.yml

@@ -18,7 +18,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v4
         with:
-          go-version: 1.23.x
+          go-version: 1.26.x
           cache: false
       - name: Install fuse
         run: sudo apt-get update && sudo apt-get install -y fuse3 libfuse-dev

Dockerfile

@@ -17,7 +17,7 @@
 # Mount the gcsfuse to /mnt/gcs:
 #  > docker run --privileged --device /fuse -v /mnt/gcs:/gcs:rw,rshared gcsfuse
 
-FROM golang:1.23.0-alpine as builder
+FROM golang:1.26.1-alpine as builder
 
 RUN apk add git
 

go.mod

@@ -1,6 +1,6 @@
 module github.com/googlecloudplatform/gcsfuse/v2
 
-go 1.23.0
+go 1.26.1
 
 require (
 	cloud.google.com/go/compute/metadata v0.5.0

internal/cache/file/downloader/job.go

@@ -468,7 +468,7 @@ func (job *Job) Download(ctx context.Context, offset int64, waitForDownload bool
 	job.mu.Lock()
 	if int64(job.object.Size) < offset {
 		defer job.mu.Unlock()
-		err = fmt.Errorf(fmt.Sprintf("Download: the requested offset %d is greater than the size of object %d", offset, job.object.Size))
+		err = fmt.Errorf("Download: the requested offset %d is greater than the size of object %d", offset, job.object.Size)
 		return job.status, err
 	}
 

internal/cache/file/downloader/job_test.go

@@ -680,7 +680,7 @@ func (dt *downloaderTest) Test_Download_Concurrent() {
 	ctx := context.Background()
 	wg := sync.WaitGroup{}
 	offsets := []int64{0, 4 * util.MiB, 16 * util.MiB, 8 * util.MiB, int64(objectSize), int64(objectSize) + 1}
-	expectedErrs := []error{nil, nil, nil, nil, nil, fmt.Errorf(fmt.Sprintf("Download: the requested offset %d is greater than the size of object %d", int64(objectSize)+1, int64(objectSize)))}
+	expectedErrs := []error{nil, nil, nil, nil, nil, fmt.Errorf("Download: the requested offset %d is greater than the size of object %d", int64(objectSize)+1, int64(objectSize))}
 	downloadFunc := func(expectedOffset int64, expectedErr error) {
 		defer wg.Done()
 		var jobStatus JobStatus

internal/logger/logger.go

@@ -159,7 +159,7 @@ func Errorf(format string, v ...interface{}) {
 // Fatal prints an error log and exits with non-zero exit code.
 func Fatal(format string, v ...interface{}) {
 	Errorf(format, v...)
-	Errorf(string(debug.Stack()))
+	Errorf("%s", string(debug.Stack()))
 	os.Exit(1)
 }
 

perfmetrics/scripts/ml_tests/pytorch/run_model.sh

@@ -20,7 +20,7 @@ NUM_EPOCHS=80
 TEST_BUCKET="gcsfuse-ml-data"
 
 # Install golang
-wget -O go_tar.tar.gz https://go.dev/dl/go1.23.0.linux-amd64.tar.gz -q
+wget -O go_tar.tar.gz https://go.dev/dl/go1.26.1.linux-amd64.tar.gz -q
 rm -rf /usr/local/go && tar -C /usr/local -xzf go_tar.tar.gz
 export PATH=$PATH:/usr/local/go/bin
 

perfmetrics/scripts/ml_tests/tf/resnet/setup_scripts/setup_container.sh

@@ -13,13 +13,13 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-# Installs go1.23.0 on the container, builds gcsfuse using log_rotation file
+# Installs go1.26.1 on the container, builds gcsfuse using log_rotation file
 # and installs tf-models-official v2.13.2, makes update to include clear_kernel_cache
 # and epochs functionality, and runs the model
 
 # Install go lang
 BUCKET_TYPE=$1
-wget -O go_tar.tar.gz https://go.dev/dl/go1.23.0.linux-amd64.tar.gz -q
+wget -O go_tar.tar.gz https://go.dev/dl/go1.26.1.linux-amd64.tar.gz -q
 sudo rm -rf /usr/local/go && tar -xzf go_tar.tar.gz && sudo mv go /usr/local
 export PATH=$PATH:/usr/local/go/bin
 

perfmetrics/scripts/presubmit_test/pr_perf_test/build.sh

@@ -40,8 +40,8 @@ set -e
 sudo apt-get update
 echo Installing git
 sudo apt-get install git
-echo Installing go-lang  1.23.0
-wget -O go_tar.tar.gz https://go.dev/dl/go1.23.0.linux-amd64.tar.gz -q
+echo Installing go-lang  1.26.1
+wget -O go_tar.tar.gz https://go.dev/dl/go1.26.1.linux-amd64.tar.gz -q
 sudo rm -rf /usr/local/go && tar -xzf go_tar.tar.gz && sudo mv go /usr/local
 export PATH=$PATH:/usr/local/go/bin
 export CGO_ENABLED=0

perfmetrics/scripts/read_cache/setup.sh

@@ -64,7 +64,7 @@ sed -i 's/define \+FIO_IO_U_PLAT_GROUP_NR \+\([0-9]\+\)/define FIO_IO_U_PLAT_GRO
 cd -
 
 # Install and validate go.
-version=1.23.0
+version=1.26.1
 wget -O go_tar.tar.gz https://go.dev/dl/go${version}.linux-amd64.tar.gz -q
 sudo rm -rf /usr/local/go
 tar -xzf go_tar.tar.gz && sudo mv go /usr/local

tools/cd_scripts/e2e_test.sh

@@ -111,7 +111,7 @@ else
 fi
 
 # install go
-wget -O go_tar.tar.gz https://go.dev/dl/go1.23.0.linux-${architecture}.tar.gz
+wget -O go_tar.tar.gz https://go.dev/dl/go1.26.1.linux-${architecture}.tar.gz
 sudo tar -C /usr/local -xzf go_tar.tar.gz
 export PATH=${PATH}:/usr/local/go/bin
 #Write gcsfuse and go version to log file

tools/containerize_gcsfuse_docker/Dockerfile

@@ -34,7 +34,7 @@ ARG OS_VERSION
 ARG OS_NAME
 
 # Image with gcsfuse installed and its package (.deb)
-FROM golang:1.23.0 as gcsfuse-package
+FROM golang:1.26.1 as gcsfuse-package
 
 RUN apt-get update -qq && apt-get install -y ruby ruby-dev rubygems build-essential rpm fuse && gem install --no-document bundler
 

tools/integration_tests/managed_folders/test_helper.go

@@ -72,18 +72,18 @@ func providePermissionToManagedFolder(bucket, managedFolderPath, serviceAccount,
 	// Indent for readability
 	jsonData, err := json.MarshalIndent(policy, "", "  ")
 	if err != nil {
-		t.Fatalf(fmt.Sprintf("Error in marshal the data into JSON format: %v", err))
+		t.Fatalf("Error in marshal the data into JSON format: %v", err)
 	}
 
 	localIAMPolicyFilePath := path.Join(os.Getenv("HOME"), "iam_policy.json")
 	// Write the JSON to a FileInNonEmptyManagedFoldersTest
 	err = os.WriteFile(localIAMPolicyFilePath, jsonData, setup.FilePermission_0600)
 	if err != nil {
-		t.Fatalf(fmt.Sprintf("Error in writing iam policy in json FileInNonEmptyManagedFoldersTest : %v", err))
+		t.Fatalf("Error in writing iam policy in json FileInNonEmptyManagedFoldersTest : %v", err)
 	}
 
 	gcloudProvidePermissionCmd := fmt.Sprintf("alpha storage managed-folders set-iam-policy gs://%s/%s %s", bucket, managedFolderPath, localIAMPolicyFilePath)
-	_, err = operations.ExecuteGcloudCommandf(gcloudProvidePermissionCmd)
+	_, err = operations.ExecuteGcloudCommandf("%s", gcloudProvidePermissionCmd)
 	if err != nil {
 		t.Fatalf("Error in providing permission to managed folder: %v", err)
 	}
@@ -92,7 +92,7 @@ func providePermissionToManagedFolder(bucket, managedFolderPath, serviceAccount,
 func revokePermissionToManagedFolder(bucket, managedFolderPath, serviceAccount, iamRole string, t *testing.T) {
 	gcloudRevokePermissionCmd := fmt.Sprintf("alpha storage managed-folders remove-iam-policy-binding  gs://%s/%s --member=%s --role=%s", bucket, managedFolderPath, serviceAccount, iamRole)
 
-	_, err := operations.ExecuteGcloudCommandf(gcloudRevokePermissionCmd)
+	_, err := operations.ExecuteGcloudCommandf("%s", gcloudRevokePermissionCmd)
 	if err != nil && !strings.Contains(err.Error(), "Policy binding with the specified principal, role, and condition not found!") && !strings.Contains(err.Error(), "The specified managed folder does not exist.") {
 		t.Fatalf("Error in removing permission to managed folder: %v", err)
 	}

tools/integration_tests/run_e2e_tests.sh

@@ -134,8 +134,8 @@ function upgrade_gcloud_version() {
 function install_packages() {
   # e.g. architecture=arm64 or amd64
   architecture=$(dpkg --print-architecture)
-  echo "Installing go-lang 1.23.0..."
-  wget -O go_tar.tar.gz https://go.dev/dl/go1.23.0.linux-${architecture}.tar.gz -q
+  echo "Installing go-lang 1.26.1..."
+  wget -O go_tar.tar.gz https://go.dev/dl/go1.26.1.linux-${architecture}.tar.gz -q
   sudo rm -rf /usr/local/go && tar -xzf go_tar.tar.gz && sudo mv go /usr/local
   export PATH=$PATH:/usr/local/go/bin
   # install python3-setuptools tools.

tools/integration_tests/util/creds_tests/creds.go

@@ -58,7 +58,7 @@ func CreateCredentials() (serviceAccount, localKeyFilePath string) {
 
 	// Download credentials
 	gcloudSecretAccessCmd := fmt.Sprintf("secrets versions access latest --secret %s", CredentialsSecretName)
-	creds, err := operations.ExecuteGcloudCommandf(gcloudSecretAccessCmd)
+	creds, err := operations.ExecuteGcloudCommandf("%s", gcloudSecretAccessCmd)
 	if err != nil {
 		setup.LogAndExit(fmt.Sprintf("Error while fetching key file %v", err))
 	}
@@ -79,7 +79,7 @@ func CreateCredentials() (serviceAccount, localKeyFilePath string) {
 
 func ApplyPermissionToServiceAccount(serviceAccount, permission, bucket string) {
 	// Provide permission to service account for testing.
-	_, err := operations.ExecuteGcloudCommandf(fmt.Sprintf("storage buckets add-iam-policy-binding gs://%s --member=serviceAccount:%s --role=roles/storage.%s", bucket, serviceAccount, permission))
+	_, err := operations.ExecuteGcloudCommandf("storage buckets add-iam-policy-binding gs://%s --member=serviceAccount:%s --role=roles/storage.%s", bucket, serviceAccount, permission)
 	if err != nil {
 		setup.LogAndExit(fmt.Sprintf("Error while setting permissions to SA: %v", err))
 	}
@@ -91,7 +91,7 @@ func ApplyPermissionToServiceAccount(serviceAccount, permission, bucket string)
 func RevokePermission(serviceAccount, permission, bucket string) {
 	// Revoke the permission to service account after testing.
 	cmd := fmt.Sprintf("storage buckets remove-iam-policy-binding gs://%s --member=serviceAccount:%s --role=roles/storage.%s", bucket, serviceAccount, permission)
-	_, err := operations.ExecuteGcloudCommandf(cmd)
+	_, err := operations.ExecuteGcloudCommandf("%s", cmd)
 	if err != nil {
 		setup.LogAndExit(fmt.Sprintf("Error in unsetting permissions to SA: %v", err))
 	}

tools/integration_tests/util/operations/dir_operations.go

@@ -172,26 +172,26 @@ func DirSizeMiB(dirPath string) (dirSizeMB int64, err error) {
 func DeleteManagedFoldersInBucket(managedFolderPath, bucket string) {
 	gcloudDeleteManagedFolderCmd := fmt.Sprintf("alpha storage rm -r gs://%s/%s", bucket, managedFolderPath)
 
-	_, err := ExecuteGcloudCommandf(gcloudDeleteManagedFolderCmd)
+	_, err := ExecuteGcloudCommandf("%s", gcloudDeleteManagedFolderCmd)
 	if err != nil && !strings.Contains(err.Error(), "The following URLs matched no objects or files") {
-		log.Fatalf(fmt.Sprintf("Error while deleting managed folder: %v", err))
+		log.Fatalf("Error while deleting managed folder: %v", err)
 	}
 }
 
 func CreateManagedFoldersInBucket(managedFolderPath, bucket string) {
 	gcloudCreateManagedFolderCmd := fmt.Sprintf("alpha storage managed-folders create gs://%s/%s", bucket, managedFolderPath)
 
-	_, err := ExecuteGcloudCommandf(gcloudCreateManagedFolderCmd)
+	_, err := ExecuteGcloudCommandf("%s", gcloudCreateManagedFolderCmd)
 	if err != nil && !strings.Contains(err.Error(), "The specified managed folder already exists") {
-		log.Fatalf(fmt.Sprintf("Error while creating managed folder: %v", err))
+		log.Fatalf("Error while creating managed folder: %v", err)
 	}
 }
 
 func CopyFileInBucket(srcfilePath, destFilePath, bucket string, t *testing.T) {
 	gcloudCopyFileCmd := fmt.Sprintf("alpha storage cp %s gs://%s/%s/", srcfilePath, bucket, destFilePath)
 
-	_, err := ExecuteGcloudCommandf(gcloudCopyFileCmd)
+	_, err := ExecuteGcloudCommandf("%s", gcloudCopyFileCmd)
 	if err != nil {
-		t.Fatalf(fmt.Sprintf("Error while copying file in bucket: %v", err))
+		t.Fatalf("Error while copying file in bucket: %v", err)
 	}
 }

tools/package_gcsfuse_docker/Dockerfile

@@ -17,7 +17,7 @@
 # Copy the gcsfuse packages to the host:
 #   > docker run -it -v /tmp:/output gcsfuse-release cp -r /packages /output
 
-FROM golang:1.23.0 as builder
+FROM golang:1.26.1 as builder
 
 RUN apt-get update -qq && apt-get install -y ruby ruby-dev rubygems build-essential rpm && gem install --no-document bundler
 

tools/prefetch_cache_gcsfuse/prefetch.go

@@ -33,7 +33,7 @@ import (
 const NUM_WORKERS = 10
 
 func downloadFile(ctx context.Context, client *storage.Client, object *storage.ObjectAttrs, cacheDir string) (err error) {
-	log.Printf(fmt.Sprintf("downloading file %v from bucket %v into dir %v", object.Name, object.Bucket, cacheDir))
+	log.Printf("downloading file %v from bucket %v into dir %v", object.Name, object.Bucket, cacheDir)
 
 	// We may want a way to verify the files are fully downloaded
 	// and either resuming the download or discarding and redownloading the file