Skip to content

test(integration): migrate buffered read test pacakge#4583

Open
PranjalC100 wants to merge 5 commits intomasterfrom
test-migration-buffered-read
Open

test(integration): migrate buffered read test pacakge#4583
PranjalC100 wants to merge 5 commits intomasterfrom
test-migration-buffered-read

Conversation

@PranjalC100
Copy link
Copy Markdown
Member

@PranjalC100 PranjalC100 commented Apr 5, 2026 •
edited
Loading

Description

This PR migrates the buffered_read integration tests to use the new YAML-based test configuration framework.

Link to the issue in case of a bug fix.

https://buganizer.corp.google.com/issues/499884767

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - Passing for the newly migrated buffered read tests.

Any backward incompatible change? If so, please explain.

No.

@PranjalC100 PranjalC100 added execute-integration-tests Run only integration tests execute-integration-tests-on-zb To run E2E tests on zonal bucket. labels Apr 5, 2026
@PranjalC100 PranjalC100 force-pushed the test-migration-buffered-read branch from 6327824 to ae7bc21 Compare April 6, 2026 05:20
@PranjalC100 PranjalC100 requested a review from ashmeenkaur April 6, 2026 06:16
@PranjalC100 PranjalC100 marked this pull request as ready for review April 6, 2026 06:21
@PranjalC100 PranjalC100 requested review from a team, Tulsishah and meet2mky as code owners April 6, 2026 06:21
@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist bot commented Apr 6, 2026

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request migrates the buffered_read integration tests to the project's standardized YAML-based test configuration framework. This change improves maintainability and consistency across the test suite by centralizing configuration management and removing hardcoded flag logic from individual test files.

Highlights

  • Migration to YAML-based Configuration: Migrated the buffered_read integration tests to utilize the centralized YAML-based test configuration framework, replacing manual flag construction.
  • Test Suite Refactoring: Refactored test suites to use a shared environment configuration (testEnv) and updated setup/teardown logic to support the new configuration structure.
  • Configuration Updates: Added buffered_read configuration entries to the main test_config.yaml file and updated the test suite configuration model to support these new settings.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@github-actions github-actions bot added the remind-reviewers Auto remind reviewers in attention set for review post 24hrs of inactivity on PR. label Apr 6, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (3c6a9f4) to head (3e3efa5).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #4583       +/-   ##
==========================================
- Coverage   83.63%       0   -83.64%     
==========================================
  Files         164       0      -164     
  Lines       20212       0    -20212     
==========================================
- Hits        16904       0    -16904     
+ Misses       2669       0     -2669     
+ Partials      639       0      -639
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

gemini-code-assist[bot]
gemini-code-assist bot reviewed Apr 6, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the buffered read integration tests to use a centralized configuration system and a new test environment structure, replacing local flag management with test_suite utilities. Key changes include updating test suites to run with multiple flag sets from test_config.yaml and refactoring TestMain for config-based setup. Feedback identifies unused variables mountDir and rootDir in setup_test.go and recommends dynamically extracting block sizes in tests to avoid tight coupling with specific configuration values.

Comment thread tools/integration_tests/buffered_read/setup_test.go Outdated
Comment thread tools/integration_tests/buffered_read/sequential_read_test.go Outdated
ashmeenkaur
ashmeenkaur reviewed Apr 6, 2026
View reviewed changes
Comment thread tools/integration_tests/buffered_read/fallback_test.go Outdated
ashmeenkaur
ashmeenkaur previously approved these changes Apr 6, 2026
View reviewed changes
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026

Hi @meet2mky, @Tulsishah, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

1 similar comment
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026

Hi @meet2mky, @Tulsishah, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

@PranjalC100 PranjalC100 force-pushed the test-migration-buffered-read branch from 018ce93 to 4d152a0 Compare April 9, 2026 05:59
@PranjalC100
Copy link
Copy Markdown
Member Author

PranjalC100 commented Apr 9, 2026 •
edited
Loading

After approval: Did a rebase with master to resolve merge conflicts, and used blockSizeInBytes at one place.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 10, 2026

Hi @meet2mky, @Tulsishah, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

1 similar comment
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 13, 2026

Hi @meet2mky, @Tulsishah, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

ashmeenkaur
ashmeenkaur previously approved these changes Apr 13, 2026
View reviewed changes
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 14, 2026

Hi @meet2mky, @Tulsishah, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

1 similar comment
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 15, 2026

Hi @meet2mky, @Tulsishah, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

@PranjalC100 PranjalC100 force-pushed the test-migration-buffered-read branch from e607baf to f80dc76 Compare April 15, 2026 09:44
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 16, 2026

Hi @meet2mky, @Tulsishah, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

1 similar comment
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 17, 2026

Hi @meet2mky, @Tulsishah, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashmeenkaur ashmeenkaur ashmeenkaur left review comments

@meet2mky meet2mky Awaiting requested review from meet2mky meet2mky is a code owner

@Tulsishah Tulsishah Awaiting requested review from Tulsishah

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

execute-integration-tests Run only integration tests execute-integration-tests-on-zb To run E2E tests on zonal bucket. remind-reviewers Auto remind reviewers in attention set for review post 24hrs of inactivity on PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PranjalC100 @ashmeenkaur