refactor(append): Log mismatched offsets on takeover errors

[cjc25]

When takeover offset doesn't match the requested offset, logs are more useful if we know what each value was.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the observability of errors occurring during the creation of appendable object writers. By including specific offset values in the error message, it becomes easier to diagnose issues related to stale object views and metadata cache inconsistencies.

Highlights

• Enhanced Error Logging: Updated the error message in the bucket handle to include the actual and requested offsets when a mismatch occurs during object writer takeover.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request improves error reporting in internal/storage/bucket_handle.go by including the specific offset values in the error message when a mismatch occurs. A review comment suggests using the %d format specifier instead of %v for these integer offsets to better align with idiomatic Go practices.

[gemini-code-assist]

For better clarity and adherence to Go's idiomatic practices, it's recommended to use the %d format specifier for integer types instead of the general %v. This makes the expected type more explicit to readers of the code.

Suggested change

	err = fmt.Errorf("takeover offset %v for the created appendable object writer does not match the requested offset %v", off, req.Offset)
	err = fmt.Errorf("takeover offset %d for the created appendable object writer does not match the requested offset %d", off, req.Offset)