Skip to content

samples(Storage Batch Operations): Add samples and tests for storage batch operations#3127

Open
mahendra-google wants to merge 19 commits intoGoogleCloudPlatform:mainfrom
mahendra-google:sbo
Open

samples(Storage Batch Operations): Add samples and tests for storage batch operations#3127
mahendra-google wants to merge 19 commits intoGoogleCloudPlatform:mainfrom
mahendra-google:sbo

Conversation

@mahendra-google
Copy link
Copy Markdown
Contributor

@mahendra-google mahendra-google commented Jun 23, 2025 •
edited by krishnamd-jkp
Loading

This PR contains samples and test cases to create, list, get, cancel and delete storage batch job operations.

The region tags used to create samples are as below:-

  • 1. storage_batch_create_job

  • 2. storage_batch_list_jobs

  • 3. storage_batch_get_job
  • 4. storage_batch_cancel_job
  • 5. storage_batch_delete_job

@mahendra-google mahendra-google requested review from a team as code owners June 23, 2025 13:31
@snippet-bot
Copy link
Copy Markdown

snippet-bot bot commented Jun 23, 2025 •
edited
Loading

Here is the summary of changes.

You are about to add 8 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jun 23, 2025
@purva9413 purva9413 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 23, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 23, 2025
@mahendra-google
Copy link
Copy Markdown
Contributor Author

mahendra-google commented Jun 27, 2025 •
edited
Loading

@purva9413 After looking at errors from build log , I think Storage Batch Operations APIs are not enabled on both Kokoro servers i.e. Kokoro CI Linux 3 and Kokoro CI Windows 3.

@purva9413 purva9413 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 30, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 30, 2025
@purva9413 purva9413 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 1, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 1, 2025
@purva9413
Copy link
Copy Markdown

purva9413 commented Jul 1, 2025

The API has been enabled but there are failing tests. Please take a look and also please address comments from the review. Thanks!

@mahendra-google
Copy link
Copy Markdown
Contributor Author

mahendra-google commented Jul 16, 2025

@purva9413 This test is not failing locally. Could you add kokoro label once I have done some code changes?

@purva9413 purva9413 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 17, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 17, 2025
@mahendra-google
Copy link
Copy Markdown
Contributor Author

mahendra-google commented Jul 23, 2025 •
edited
Loading

@purva9413 Could you add kokoro label again?. This time I have added the null-conditional operator (?.) for all retrievedResponse properties and also added console logs to print those individual values to find exactly which value is null.

@purva9413 purva9413 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 24, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 24, 2025
@mahendra-google
Copy link
Copy Markdown
Contributor Author

mahendra-google commented Jul 28, 2025

@purva9413 This PR is ready for review.

@purva9413 purva9413 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 30, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 30, 2025
purva9413
purva9413 suggested changes Aug 4, 2025
View reviewed changes
Comment thread storagebatchoperations/api/runTests.ps1 Outdated
Comment thread storagebatchoperations/api/StorageBatchOperations.Samples.Tests/CancelBatchJobTest.cs Outdated
Comment thread storagebatchoperations/api/StorageBatchOperations.Samples.Tests/CancelBatchJobTest.cs Outdated
@mahendra-google
Copy link
Copy Markdown
Contributor Author

mahendra-google commented Aug 20, 2025

@purva9413 Could you review the retry logic implemented as a part of the recent code changes, with reference to the IAM pull request?

@purva9413 purva9413 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 8, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 8, 2025
purva9413
purva9413 reviewed Sep 8, 2025
View reviewed changes
Comment thread storagebatchoperations/api/StorageBatchOperations.Samples.Tests/StorageFixture.cs Outdated
@purva9413
Copy link
Copy Markdown

purva9413 commented Sep 8, 2025

Please fix failing tests.

@krishnamd-jkp krishnamd-jkp added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 9, 2026
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 9, 2026
@krishnamd-jkp krishnamd-jkp added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 9, 2026
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 9, 2026
@krishnamd-jkp krishnamd-jkp added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 10, 2026
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 10, 2026
@krishnamd-jkp krishnamd-jkp added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 10, 2026
@mahendra-google
refactor(Storage Batch Operations): Remove unused KMS fields in Creat…
626eb8f 
…eBatchJobTest

Remove unused private fields `_kmsKey`, `_keyRingId`, `_cryptoKeyId`, and `_cryptoKeyName` from CreateBatchJobTest to improve code clarity and maintainability.
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 10, 2026
@krishnamd-jkp krishnamd-jkp added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 13, 2026
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 13, 2026
@krishnamd-jkp krishnamd-jkp added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 13, 2026
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 13, 2026
@mahendra-google
tests(Storage Batch Operations): Stabilize cancelBatchJobTest by incr…
c38ef3e 
…easing retry attempts

Extended the retry attempts in cancelBatchJobTest from 100 to 1000. This ensures the test accounts for delayed state transitions in the Koko environment while maintaining efficiency via an early exit once the 'Canceled' state is reached.
@krishnamd-jkp krishnamd-jkp added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 13, 2026
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 13, 2026
@mahendra-google
chore(Storage Batch Operations): Update dependencies
f1ddbbf 
Updated Google.Cloud.Storage.V1 to 4.14.0 and Google.Cloud.StorageBatchOperations.V1 to 1.0.0-beta05.
krishnamd-jkp
krishnamd-jkp reviewed Apr 14, 2026
View reviewed changes
Comment thread storagebatchoperations/api/StorageBatchOperations.Samples/CreateBatchJob.cs Outdated
Comment thread storagebatchoperations/api/StorageBatchOperations.Samples/CreateBatchJob.cs Outdated
Comment thread storagebatchoperations/api/StorageBatchOperations.Samples.Tests/CreateBatchJobTest.cs Outdated
@krishnamd-jkp krishnamd-jkp added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 15, 2026
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@krishnamd-jkp krishnamd-jkp krishnamd-jkp approved these changes

@purva9413 purva9413 Awaiting requested review from purva9413

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mahendra-google @purva9413 @krishnamd-jkp @kokoro-team @robertvoinescu-work