Improve code readability per Issue #133#178
Open
hrsubhut wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
Open
Improve code readability per Issue #133#178hrsubhut wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
hrsubhut wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
Conversation
…odernize ingest_flights.py (Issue GoogleCloudPlatform#133)Improve code readability and modernize ingest_flights.py (Issue GoogleCloudPlatform#133)Refactor ingest_flights.py for clarity and maintainability - Added comprehensive docstrings to all functions - Converted all .format() calls to f-strings for better readability - Simplified zip extraction with Path parameter using pathlib - Verified code compliance with Python 3.8 standards - Improved overall code documentation and maintainabilityRefactor ingest_flights.py to improve readability and maintainability. Updated logging statements for consistency and clarity, and replaced os.path with pathlib for better path handling.
…ython 3 and enhance logging Convert .format() calls to f-strings, add comprehensive docstring to Flask endpoint function, and update shebang to Python 3 for consistency with ingest_flights.py improvements.Updated shebang to use Python 3 and improved logging format.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request addresses Issue #133 by modernizing and improving code readability in the
02_ingest/monthlyupdatemodule.Changes Made
Improved Documentation
Python 3.8+ Modernization
.format()string formatting to f-strings for better readability#!/usr/bin/env pythonto#!/usr/bin/env python3os.pathoperations with modernpathlib.Pathwhere appropriateCode Simplification
pathparameter instead of changing directoriesos.chdir()operationsRelated Issue
Fixes #133
Files Modified
02_ingest/monthlyupdate/ingest_flights.py: Major refactoring with docstrings and f-strings02_ingest/monthlyupdate/main.py: Added docstrings and modernized string formatting