Skip to content

[GCS_Text_to_Cloud_Spanner] Handling all the exceptions during CSV parsing and writing all the errored CSV records to GCS#3709

Merged
darshan-sj merged 4 commits intoGoogleCloudPlatform:mainfrom
darshan-sj:csv-import-fix
Apr 20, 2026
Merged

[GCS_Text_to_Cloud_Spanner] Handling all the exceptions during CSV parsing and writing all the errored CSV records to GCS#3709
darshan-sj merged 4 commits intoGoogleCloudPlatform:mainfrom
darshan-sj:csv-import-fix

Conversation

@darshan-sj
Copy link
Copy Markdown
Contributor

Handling all the exceptions during CSV parsing and writing all the errored CSV records to GCS

@darshan-sj darshan-sj requested a review from a team as a code owner April 19, 2026 17:37
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the robustness of the CSV to Cloud Spanner data pipeline by broadening the exception handling scope during record processing. By catching all exceptions, the system can now more reliably capture and persist malformed or problematic records to a designated GCS location instead of failing the entire pipeline execution.

Highlights

  • Exception Handling: Updated the CSV parsing logic to catch all exceptions instead of only IllegalArgumentException.
  • Error Reporting: Ensured that all failed CSV records are correctly routed to the configured GCS error path.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@darshan-sj darshan-sj added the improvement Making existing code better label Apr 19, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.56%. Comparing base (b8203be) to head (2ad888e).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3709      +/-   ##
============================================
+ Coverage     52.52%   52.56%   +0.04%     
+ Complexity     6251     5853     -398     
============================================
  Files          1065     1065              
  Lines         64318    64404      +86     
  Branches       7119     7126       +7     
============================================
+ Hits          33782    33855      +73     
- Misses        28256    28267      +11     
- Partials       2280     2282       +2     
Components Coverage Δ
spanner-templates 72.21% <100.00%> (+0.05%) ⬆️
spanner-import-export 68.65% <100.00%> (-0.02%) ⬇️
spanner-live-forward-migration 80.87% <ø> (ø)
spanner-live-reverse-replication 77.54% <ø> (-0.05%) ⬇️
spanner-bulk-migration 89.42% <ø> (+0.02%) ⬆️
gcs-spanner-dv 85.75% <ø> (ø)
Files with missing lines Coverage Δ
...le/cloud/teleport/spanner/CSVRecordToMutation.java 80.00% <100.00%> (ø)

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@darshan-sj darshan-sj merged commit 423263a into GoogleCloudPlatform:main Apr 20, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Making existing code better size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants