Add minRowCountForPageSizeCheck setting to BigTableToParquet template.#3644
Add minRowCountForPageSizeCheck setting to BigTableToParquet template.#3644claudevdm wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a configurable setting to the BigtableToParquet template, allowing users to specify the minimum row count for page size checks. This change helps mitigate potential memory issues when processing large rows by providing more granular control over how frequently pages are flushed to storage. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #3644 +/- ##
============================================
- Coverage 52.33% 52.31% -0.02%
+ Complexity 6158 5746 -412
============================================
Files 1054 1054
Lines 63624 63628 +4
Branches 6997 6998 +1
============================================
- Hits 33296 33288 -8
- Misses 28070 28080 +10
- Partials 2258 2260 +2
🚀 New features to boost your workflow:
|
| */ | ||
| ParquetIO.Sink parquetSink = ParquetIO.sink(BigtableRow.getClassSchema()); | ||
| ValueProvider<Integer> minRowCountOpt = options.getMinRowCountForPageSizeCheck(); | ||
| if (minRowCountOpt.isAccessible() && minRowCountOpt.get() != null) { |
There was a problem hiding this comment.
value provider isn't accessible at pipeline expansion time (in public static PipelineResult run)
No description provided.