Skip to content

Add minRowCountForPageSizeCheck setting to BigTableToParquet template.#3644

Open
claudevdm wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
claudevdm:parquetio-minsize
Open

Add minRowCountForPageSizeCheck setting to BigTableToParquet template.#3644
claudevdm wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
claudevdm:parquetio-minsize

Conversation

@claudevdm
Copy link
Copy Markdown
Contributor

No description provided.

@claudevdm claudevdm requested a review from a team as a code owner April 8, 2026 13:48
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a configurable setting to the BigtableToParquet template, allowing users to specify the minimum row count for page size checks. This change helps mitigate potential memory issues when processing large rows by providing more granular control over how frequently pages are flushed to storage.

Highlights

  • New Pipeline Option: Added a new configuration parameter 'minRowCountForPageSizeCheck' to the BigtableToParquet template to control memory usage during Parquet file writing.
  • Dynamic Sink Configuration: Updated the pipeline logic to conditionally apply the new row count threshold to the Parquet sink if provided by the user.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.31%. Comparing base (afbc8a7) to head (ca342f4).

Files with missing lines Patch % Lines
...gle/cloud/teleport/bigtable/BigtableToParquet.java 0.00% 5 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3644      +/-   ##
============================================
- Coverage     52.33%   52.31%   -0.02%     
+ Complexity     6158     5746     -412     
============================================
  Files          1054     1054              
  Lines         63624    63628       +4     
  Branches       6997     6998       +1     
============================================
- Hits          33296    33288       -8     
- Misses        28070    28080      +10     
- Partials       2258     2260       +2     
Components Coverage Δ
spanner-templates 72.17% <ø> (-0.02%) ⬇️
spanner-import-export 68.90% <ø> (-0.02%) ⬇️
spanner-live-forward-migration 80.41% <ø> (-0.04%) ⬇️
spanner-live-reverse-replication 77.84% <ø> (-0.03%) ⬇️
spanner-bulk-migration 89.17% <ø> (-0.02%) ⬇️
gcs-spanner-dv 85.34% <ø> (-0.05%) ⬇️
Files with missing lines Coverage Δ
...gle/cloud/teleport/bigtable/BigtableToParquet.java 34.61% <0.00%> (-2.89%) ⬇️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@claudevdm claudevdm requested a review from Abacn April 8, 2026 16:28
*/
ParquetIO.Sink parquetSink = ParquetIO.sink(BigtableRow.getClassSchema());
ValueProvider<Integer> minRowCountOpt = options.getMinRowCountForPageSizeCheck();
if (minRowCountOpt.isAccessible() && minRowCountOpt.get() != null) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

value provider isn't accessible at pipeline expansion time (in public static PipelineResult run)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants