feat: Create/Update changes for RSS feed notif channel support#2397
Open
feat: Create/Update changes for RSS feed notif channel support#2397
Conversation
jcscottiii
approved these changes
Apr 8, 2026
Collaborator
jcscottiii
left a comment
jcscottiii
left a comment
There was a problem hiding this comment.
LGTM with two nits to help. Feel free to do those now or in a follow up.
Comment on lines
52
to
56
| } else if cfg, err := request.Config.AsRSSConfig(); err == nil && | ||
| cfg.Type == backend.RSSConfigTypeRss { | ||
| // RSS channels currently have no configuration fields to validate. | ||
| _ = cfg | ||
| } else { |
neilv-g
force-pushed
the
neilv-rss-2
branch
5 times, most recently
from
4617729 to
74df9ec
Compare
neilv-g
force-pushed
the
neilv-rss-3
branch
3 times, most recently
from
a5c1cc6 to
1c9daf9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Read and Delete NotifChannel APIs should work as is and not need any changes for RSS feeds.