Fix debugger example to use Fetch.enable with URL patterns to prevent…#1667
Open
Shreyans-704 wants to merge 1 commit intoGoogleChrome:mainfrom
Open
Fix debugger example to use Fetch.enable with URL patterns to prevent…#1667Shreyans-704 wants to merge 1 commit intoGoogleChrome:mainfrom
Shreyans-704 wants to merge 1 commit intoGoogleChrome:mainfrom
Conversation
… chrome-extension access errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1236
Summary
Fix the debugger sample to prevent the runtime error:
"Unchecked runtime.lastError: Cannot access a chrome-extension:// URL of different extension."
Problem
The current implementation uses
Fetch.enablewithout restricting URL patterns, causing it to intercept all requests — includingchrome-extension://URLs.Chrome does not allow extensions to access resources of other extensions, which leads to the runtime error when such requests are intercepted.
Solution
Restrict
Fetch.enableto only intercept valid web requests (httpandhttps) by updating the URL patterns:javascript
patterns: [
{ urlPattern: 'http*:///' }
]