Skip to content

Update bambu pr template #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lingminhao merged 3 commits into from
Apr 20, 2026
Merged

Update bambu pr template #574

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5967af9
update bambu pr template
lingminhao Apr 20, 2026
129559a
update bambu pr template
lingminhao Apr 20, 2026
48017de
update bambu pr template
lingminhao Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
*Remove unused sections before submitting. Only keep what is relevant.*

*Text marked with `<!-- Text here -->` will not be rendered*

## Related Issue
Fixes # (issue number)
<!-- e.g. Fixes #<issue_number> -->

## Type of Change
- [ ] **Bug fix** (non-breaking change which fixes an issue)
Expand All @@ -10,21 +14,29 @@ Fixes # (issue number)
- [ ] **Performance optimization**

## Description
Please provide a summary and the motivation for the changes. Why is this change necessary? What problem does it solve?
<!-- Please provide a summary and the motivation for the changes. Why is this change necessary? What problem does it solve? -->

## Implementation Details
Briefly describe how the changes were implemented. Which specific code segments or logic paths within the primary functional arguments (e.g., `demultiplexed`, `discovery`, `quant`) are affected? Include relevant technical details for any algorithmic changes or data structure modifications specific to Bambu.
<!-- Briefly describe how the changes were implemented. Which specific code segments or logic paths within the primary functional arguments (e.g., `demultiplexed`, `discovery`, `quant` — refer to the package's main function arguments) are affected? Include relevant technical details for any algorithmic changes or data structure modifications specific to Bambu. -->

## Impact of Changes
Briefly describe the impact of the implemented changes. For example:
<!-- Briefly describe the impact of the implemented changes. For example:
- Results are identical to the previous version.
- Bug fix only (no changes to output).
- Adds one column to the SE object.
- Transcript quantification results show minimal differences.
- Transcript quantification results show minimal differences. -->

## Checklist
- [ ] My code follows the style guidelines of this project.
- [ ] I have performed a self-review of my own code.
- [ ] I have verified that GitHub automated tests passed. (Describe any failing tests in the next section)
- [ ] I have commented my code, particularly in hard-to-understand areas.
- [ ] I have made corresponding changes to the documentation (vignettes, man pages).
- [ ] I have tested the code on a full dataset, and any differences have been described in the Impact of Changes section.
- [ ] I have tested the code on a full dataset, and any differences have been described in the pull request.

## Post-merge follow-up
<!-- Describe any remaining work to be done after the pull request has been merged. For example,
- Github automated tests did not pass in the original branch; this will be fixed separately.
- Unit tests for a(), b() will fail due to intentional code changes; tests will be updated post-review.
- README documentation has not been updated to depict the functionality changes to the PR; will be updated post-review.
- Known bugs to be fixed in a follow-up issue — #TODO comments added in affected code. -->
Loading