Fix: Issues with Initial Project Run#5
Open
ugurkellecioglu wants to merge 3 commits intoGetStream:mainfrom
Open
Fix: Issues with Initial Project Run#5ugurkellecioglu wants to merge 3 commits intoGetStream:mainfrom
ugurkellecioglu wants to merge 3 commits intoGetStream:mainfrom
Conversation
…o not run if someone log in with google
refactor: get public stream key from env variables
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for the project. I tried it out and noticed that some improvements could be made to help others run the project more easily.
In this PR, I have introduced a .env.template file so that newcomers can easily understand which API keys are required to get started right away.
Additionally, the public stream key was defined inline in every file. I have changed it to be a public environment variable.
Finally, if someone logs in via Google, Next.js throws an error, "Google's hostname must be included in the Next.js configuration". So I included google's hostname that they use for storing profile pictures in next config.