Skip to content

Add text fallback for social icons #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kousu wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add text fallback for social icons #547

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions app/default-files/default-themes/simple/partials/footer.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<div class="footer__social">
{{#if @config.custom.socialFacebook}}
<a href="{{@config.custom.socialFacebook}}" aria-label="Facebook">
<desc>Facebook</desc>
<svg>
<use xlink:href="{{@website.assetsUrl}}/svg/svg-map.svg#facebook"/>
</svg>
Expand All @@ -11,41 +12,47 @@
{{#if @config.custom.socialTwitter}}
<a href="{{@config.custom.socialTwitter}}" aria-label="Twitter">
<svg>
<desc>Twitter</desc>
<use xlink:href="{{@website.assetsUrl}}/svg/svg-map.svg#twitter"/>
</svg>
</a>
{{/if}}
{{#if @config.custom.socialInstagram}}
<a href="{{@config.custom.socialInstagram}}" aria-label="Instagram">
<svg>
<desc>Instagram</desc>
<use xlink:href="{{@website.assetsUrl}}/svg/svg-map.svg#instagram"/>
</svg>
</a>
{{/if}}
{{#if @config.custom.socialLinkedin}}
<a href="{{@config.custom.socialLinkedin}}" aria-label="LinkedIn">
<svg>
<desc>LinkedIn</desc>
<use xlink:href="{{@website.assetsUrl}}/svg/svg-map.svg#linkedin"/>
</svg>
</a>
{{/if}}
{{#if @config.custom.socialVimeo}}
<a href="{{@config.custom.socialVimeo}}" aria-label="Vimeo">
<svg>
<desc>Vimeo</desc>
<use xlink:href="{{@website.assetsUrl}}/svg/svg-map.svg#vimeo"/>
</svg>
</a>
{{/if}}
{{#if @config.custom.socialPinterest}}
<a href="{{@config.custom.socialPinterest}}" aria-label="Pinterest">
<svg>
<desc>Pinterest</desc>
<use xlink:href="{{@website.assetsUrl}}/svg/svg-map.svg#pinterest"/>
</svg>
</a>
{{/if}}
{{#if @config.custom.socialYoutube}}
<a href="{{@config.custom.socialYoutube}}" aria-label="Youtube">
Copy link
Copy Markdown

@pavelloz pavelloz Sep 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<a href="{{@config.custom.socialYoutube}}" aria-label="Youtube">
<a href="{{@config.custom.socialYoutube}}" aria-label="YouTube">

Copy link
Copy Markdown
Author

@kousu kousu Sep 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's already four spaces indented, just like the rest. Is this a typo?

Copy link
Copy Markdown

@YasharF YasharF Feb 10, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kousu kousu The case?

<svg>
<desc>YouTube</desc>
<use xlink:href="{{@website.assetsUrl}}/svg/svg-map.svg#youtube"/>
</svg>
</a>
Expand Down