fix: Handle EXIF orientation in uploaded gallery images (#1617, #1694).#2039
Open
myelin wants to merge 5 commits intoGetPublii:masterfrom
Open
fix: Handle EXIF orientation in uploaded gallery images (#1617, #1694).#2039myelin wants to merge 5 commits intoGetPublii:masterfrom
myelin wants to merge 5 commits intoGetPublii:masterfrom
Conversation
Author
|
Should I rebase this onto v0.46.4 or v0.47, btw? |
…, GetPublii#1694). Photoswipe needs correct width and height information for all images, or it will show them stretched to an incorrect aspect ratio. When an image is uploaded with an EXIF orientation of 6 or 8 (rotated +90 or -90 degrees), the width and height need to be swapped. Add helpers/rotation-aware-sizeof.js, which wraps the image-size module and swaps width and height if necessary.
- brittany_build.sh builds the whole thing. - dev.sh preps everything and starts the dev version. - clean.sh cleans up if you're getting weird build issues.
myelin
force-pushed
the
rotation-aware-sizeof
branch
from
3ccb351 to
bb01802
Compare
…e-editor before the big build? Back to Node 24.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Photoswipe needs correct width and height information for all images, or it will show them stretched to an incorrect aspect ratio. When an image is uploaded with an EXIF orientation of 6 or 8 (rotated +90 or -90 degrees), the width and height need to be swapped.
Add helpers/rotation-aware-sizeof.js, which wraps the image-size module and swaps width and height if necessary.