make it possible to use routing algo BATMAN-V of batman-adv#104
make it possible to use routing algo BATMAN-V of batman-adv#104
Conversation
genofire
force-pushed
the
feat/batman-v
branch
2 times, most recently
from
1dce41a to
736c288
Compare
|
I cannot say whether the change is correct, because I'm not familiar with the code. But I think we first need to decide whether we actually want to use BATMAN_V instead of BATMAN_IV. And my impression is that BATMAN_V is still experimental, and that it is not as well supported in Gluon as BATMAN_IV is. Therefore I would use BATMAN_IV. Using BATMAN_IV would mean that we would have to do another "breaking change" when we want to switch to BATMAN_V; but:
|
|
I agree with @oliver in all points |
|
Okay, should we put the code already inside the repo (with BATMAN_IV activated) ? |
| {% if batman_routing_algo == 'BATMAN_V' %} | ||
| # let batman handle the multicast | ||
| # https://gluon.readthedocs.io/en/latest/package/gluon-mesh-batman-adv.html | ||
| post-up bash -c 'echo 2 > /sys/class/net/{{ batman_dummy_interface }}/brport/multicast_router' |
| {% if batman_routing_algo is defined and batman_routing_algo == 'BATMAN_V' %} | ||
| # let batman handle the multicast | ||
| # https://gluon.readthedocs.io/en/latest/package/gluon-mesh-batman-adv.html | ||
| post-up bash -c 'echo 2 > /sys/class/net/br-{{ site_code }}/brport/multicast_router' |
There was a problem hiding this comment.
Hmm, hab ich gluon docs doch falsch verstanden ...
gerade denk
e ich, ich sollte es beim batman interface und nicht deren bridge interface.
There was a problem hiding this comment.
Und: ich hab die Doku jetzt so verstanden, dass diese Option unabhängig von BATMAN_V ist (also die ist anscheinend für BATMAN_IV und BATMAN_V sinnvoll). @genofire: kannst du nicht einen eigenen Pull Request machen, wo du nur den Commit für diese multicast_router-Option reinpackst?
| # https://gluon.readthedocs.io/en/latest/package/gluon-mesh-batman-adv.html | ||
| post-up bash -c 'echo 2 > /sys/class/net/br-{{ site_code }}/brport/multicast_router' | ||
| {% endif %} | ||
| post-up bash -c 'echo 2048 > /sys/class/net/br-{{ site_code }}/bridge/hash_max' |
There was a problem hiding this comment.
Die Zeile hab ich nur "gefixed", um die ansible variable - aber ja, der commentar ist dabei unglücklich durch die Änderung von brport/multicast_router verrutscht.
# increase multicast table
ghost
2 participants
No description provided.