Open
Conversation
hvater
commented
Mar 20, 2026
Collaborator
Author
hvater
left a comment
hvater
left a comment
There was a problem hiding this comment.
Overall I really like the changes. Nice work!
Please look at the comments and implement the suggestions. If you have any questions/differing opinions, I am open for discussion.
OliverSchw
approved these changes
Mar 26, 2026
Collaborator
OliverSchw
left a comment
OliverSchw
left a comment
There was a problem hiding this comment.
I have revised the points raised and also changed the LUT interpolator structure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrated from jax_dataclasses to equinox for states etc.
Additionally, cleaned up the vmapping procedure