Add libinjection v4 migration audit (2026-04-03)#43
Open
Easton97-Jens wants to merge 43 commits intov3/master-libinjection-v4.0-finalfrom
Open
Add libinjection v4 migration audit (2026-04-03)#43Easton97-Jens wants to merge 43 commits intov3/master-libinjection-v4.0-finalfrom
Easton97-Jens wants to merge 43 commits intov3/master-libinjection-v4.0-finalfrom
Conversation
Updated CI workflow to dynamically detect and install the latest Lua development package instead of using a fixed version.
Removed python3 from the installation steps in the CI workflow.
Removed python3 from the installation list in CI workflow.
…for-modsecurity-operators Add regression coverage for detectSQLi/detectXSS capture semantics
…for-libinjection-result_error Add libinjection adapter for test overrides and improve libinjection error handling
…r_update_workflows ci: update workflows (checkout v6, recursive submodules), prep for mbedTLS v4, Windows fixes
…transaction-usage Use ModSecurityTestContext to create per-thread transactions in multithreaded tests
…r_update_workflows Fix Lua Detection on ci_new
Refactor multithreaded unit test to use thread-specific context.
…riable-warnings Guard log-only detect operator variables under NO_LOGS
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Easton97-Jens
force-pushed
the
v3/master-libinjection-v4.0-final
branch
5 times, most recently
from
1336be4 to
52d9e75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
TRUE/FALSE/ERROR) handling and end-to-end semantic preservation.Description
doc/libinjection-v4-migration-audit-2026-04-03.mdthat contains the executive summary, call-chain analysis, findings, recommendations, and a final verdict ofPARTIALLY MIGRATED.DetectSQLi::evaluate,DetectXSS::evaluate, theisMaliciousLibinjectionResultmapping, and the boolean-only propagation inOperator::evaluateInternalandRuleWithOperator.defaultcases and structured error markers to a roadmap for changing operator interfaces to carry tri-state results.Testing
LIBINJECTION_RESULT_ERRORoverride paths fordetectSQLianddetectXSS, but those tests were observed and not run by this PR.Codex Task