Set CloseClientOnQueueFull to false by default#434
Merged
mathieucarbou merged 1 commit intomainfrom Apr 21, 2026
Merged
Conversation
mathieucarbou
force-pushed
the
issue/433
branch
2 times, most recently
from
cba42b4 to
c0fd3dd
Compare
mathieucarbou
force-pushed
the
issue/433
branch
from
c0fd3dd to
aaae2cd
Compare
This PR changes the default flag for CloseClientOnQueueFull to set it to false. false should be the sensible default for this library especially after the recent refactorings allowing for a very fast message delivery. Applications have to check the status when sending and queue status to check if they need to decrease the sending rate or close the client. Ref: #433
mathieucarbou
force-pushed
the
issue/433
branch
from
aaae2cd to
f808e44
Compare
Member
Author
|
Also updated doc (website) and examples |
me-no-dev
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the default flag for CloseClientOnQueueFull to set it to false.
false should be the sensible default for this library especially after the recent refactorings allowing for a very fast message delivery.
Applications have to check the status when sending and queue status to check if they need to decrease the sending rate or close the client.
Ref: #433