Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean ups and bugfix on mapping correction
Regarding reading a standalone mapping netCDF:
Background If the dimension size of
data(dimension of 1D ragged array such as weight, source hru) is different than sum ofnum_qhru(a array holding number of overlapping source hru for each river network hru), there are river network hru(s) that does not have any overlapping source hrus. This is indicated by 0 ofnum_qhru. See user-guide for more information.Problem&fix However, corresponding element in 1D ragged arrays to the river network hru without any source hru is also 0, though the ragged arrays should not include this (that is why sum of
num_qhruis not equal to data dimension size). There was a logical error to detect such indices in the ragged array. This PR fixes this. If a use uses such a mapping file, remapped runoff should be incorrect and get wrong answers for the rest of simulation without this fix.. Fix are inread_remap.f90This includes the other cleanups