Skip to content

Move nswbands, nlwbands to host namelist; initialize number concentration species in initialize_constituents #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jimmielin wants to merge 2 commits into
base: main
Choose a base branch
from
+49 −30
Open

Move nswbands, nlwbands to host namelist; initialize number concentration species in initialize_constituents #384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbbc265
Add number concentration species to initialize_constituents
jimmielin Apr 21, 2026
6686928
Move nswbands, nlwbands to host side namelist
jimmielin Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 0 additions & 26 deletions schemes/rrtmgp/rrtmgp_pre_namelist.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,32 +231,6 @@
<value>.false.</value>
</values>
</entry>
<entry id="nswbands">
<type>integer</type>
<category>rrtmgp</category>
<group>rrtmgp</group>
<standard_name>number_of_bands_for_shortwave_radiation</standard_name>
<units>count</units>
<desc>
Number of shortwave bands
</desc>
<values>
<value>14</value>
</values>
</entry>
<entry id="nlwbands">
<type>integer</type>
<category>rrtmgp</category>
<group>rrtmgp</group>
<standard_name>number_of_bands_for_longwave_radiation</standard_name>
<units>count</units>
<desc>
Number of longwave bands
</desc>
<values>
<value>16</value>
</values>
</entry>
<entry id="nradgas">
<type>integer</type>
<category>rrtmgp</category>
Expand Down
53 changes: 49 additions & 4 deletions test/test_schemes/initialize_constituents.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ subroutine initialize_constituents_register(constituents, errmsg, errcode)
integer :: known_const_index
integer :: found_const_count
logical :: known_constituent
real(kind_phys) :: qmin_value
character(len=256) :: cnst_stdname
character(len=256) :: variable_name
character(len=512) :: alloc_err_msg
character(len=256), allocatable :: constituent_names(:)
Expand All @@ -53,6 +55,12 @@ subroutine initialize_constituents_register(constituents, errmsg, errcode)
'cnst_NUMICE', &
'cnst_NUMSNO', &
'cnst_NUMGRA'/)
character(len=75), parameter :: water_species_number_std_names(5) = &
(/'mass_number_concentration_of_cloud_liquid_wrt_moist_air_and_condensed_water', &
'mass_number_concentration_of_rain_wrt_moist_air_and_condensed_water ', &
'mass_number_concentration_of_ice_wrt_moist_air_and_condensed_water ', &
'mass_number_concentration_of_snow_wrt_moist_air_and_condensed_water ', &
'mass_number_concentration_of_graupel_wrt_moist_air_and_condensed_water '/)

errcode = 0
errmsg = ''
Expand Down Expand Up @@ -95,6 +103,16 @@ subroutine initialize_constituents_register(constituents, errmsg, errcode)
end if
end do
end if
! Also check number concentration species
if (.not. known_constituent) then
do known_const_index = 1, size(water_species_number_concentrations)
if (trim(water_species_number_concentrations(known_const_index)) == trim(variable_name)) then
constituent_names(constituent_index) = water_species_number_std_names(known_const_index)
known_constituent = .true.
exit
end if
end do
end if
if (.not. known_constituent) then
constituent_names(constituent_index) = variable_name
end if
Expand All @@ -109,7 +127,10 @@ subroutine initialize_constituents_register(constituents, errmsg, errcode)
end if

do var_index = 1, size(constituents)
if (any(water_species_number_concentrations == trim(constituent_names(var_index)))) then
if (any(water_species_number_std_names == trim(constituent_names(var_index)))) then
! Do not set water_species = .true. for water species number concentrations
! Avoiding mismatch in properties vs. metadata-specified constituents
! Water species properties are set in air_composition.F90 in CAM-SIMA
call constituents(var_index)%instantiate( &
std_name = constituent_names(var_index), &
long_name = constituent_names(var_index), &
Expand All @@ -118,7 +139,6 @@ subroutine initialize_constituents_register(constituents, errmsg, errcode)
min_value = 0.0_kind_phys, &
advected = .true., &
diag_name = const_diag_names(var_index), &
water_species = .true., &
mixing_ratio_type = 'wet', &
errcode = errcode, &
errmsg = errmsg)
Expand All @@ -133,17 +153,42 @@ subroutine initialize_constituents_register(constituents, errmsg, errcode)
vertical_dim = 'vertical_layer_dimension', &
min_value = 0.0_kind_phys, &
advected = .true., &
diag_name = const_diag_names(var_index), &
diag_name = const_diag_names(var_index), &
mixing_ratio_type = 'wet', &
errcode = errcode, &
errmsg = errmsg)
else
! For chemistry species some special handling is necessary for qmin_value;
! this logic is replicated from chem_register in src/chemistry/mozart.
qmin_value = 0.0_kind_phys
cnst_stdname = trim(constituent_names(var_index))
! Special handling for specific chemical species
! Aerosol number density species
if (index(cnst_stdname, 'num_a') > 0) then
qmin_value = 1.e-5_kind_phys
else if (index(cnst_stdname, 'O3') > 0) then
qmin_value = 1.e-12_kind_phys
else if (index(cnst_stdname, 'CH4') > 0) then
qmin_value = 1.e-12_kind_phys
else if (index(cnst_stdname, 'N2O') > 0) then
qmin_value = 1.e-15_kind_phys
! CFCs
else if (index(cnst_stdname, 'CFC11') > 0 .or. &
index(cnst_stdname, 'CFC12') > 0 .or. &
index(cnst_stdname, 'cfc11') > 0 .or. &
index(cnst_stdname, 'cfc12') > 0) then
qmin_value = 1.e-20_kind_phys
end if
! Note: other chemistry species should be 1e-36 but we have no way
! of currently distinguishing between these and other non-chem
! constituents, so leaving as 0.0_kind_phys for now. (hplin, 11/20/25)

call constituents(var_index)%instantiate( &
std_name = constituent_names(var_index), &
long_name = constituent_names(var_index), &
units = 'kg kg-1', &
vertical_dim = 'vertical_layer_dimension', &
min_value = 0.0_kind_phys, &
min_value = qmin_value, &
advected = .true., &
diag_name = const_diag_names(var_index), &
errcode = errcode, &
Expand Down
Loading