Fix Contrast parser collapsing findings with the same rule name#14714
Open
Jino-T wants to merge 1 commit intoDefectDojo:bugfixfrom
Open
Fix Contrast parser collapsing findings with the same rule name#14714Jino-T wants to merge 1 commit intoDefectDojo:bugfixfrom
Jino-T wants to merge 1 commit intoDefectDojo:bugfixfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[sc-12973]
Summary
dupe_keyin the Contrast parser was hashed fromvuln_id_from_tool(Rule Name), causing all findings of the same rule type (e.g.ldap-injection) to be collapsed into a single findingdupe_keyto hashunique_id_from_tool(Vulnerability ID) instead, since each Contrast Vulnerability ID uniquely identifies a distinct finding instanceTest plan
test_ldap_multiple_findings— verifies that 3 findings with the same Rule Name but different Vulnerability IDs are returned as 3 distinct findings (regression test for the bug)test_duplicate_vuln_id_is_merged— verifies the merge safety net still works when a Vulnerability ID appears twice in a reporttest_example_reportandtest_example2_report— existing tests updated to reflect correct post-fix finding counts