Remove no-op await on synchronous fs calls in sync.js#2682
Open
beingsakshi wants to merge 1 commit intoDeepSourceCorp:masterfrom
Open
Remove no-op await on synchronous fs calls in sync.js#2682beingsakshi wants to merge 1 commit intoDeepSourceCorp:masterfrom
beingsakshi wants to merge 1 commit intoDeepSourceCorp:masterfrom
Conversation
|
@beingsakshi is attempting to deploy a commit to the DeepSource Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
fs.statSync and fs.readFileSync are synchronous functions that return values directly, not Promises. The await keyword before them is a no-op and misleading. The async await put(...) call (Vercel Blob API) remains unchanged as it is genuinely async.
Test plan