Skip to content

Allow QUIET=0 as temporary fix in installation scripts#3315

Open
vmcj wants to merge 1 commit intoDOMjudge:mainfrom
vmcj:quiet_sh_script_fix
Open

Allow QUIET=0 as temporary fix in installation scripts#3315
vmcj wants to merge 1 commit intoDOMjudge:mainfrom
vmcj:quiet_sh_script_fix

Conversation

@vmcj
Copy link
Copy Markdown
Member

@vmcj vmcj commented Dec 29, 2025

I encountered this when changing our update_*.sh scripts. We use QUIET=1 there, I replaced that with QUIET=0 which would enter 0 in a couple of places where we don't really need that. The same would happen with QUIET=2 which would be a strange but valid boolean.

Those fixes should make it hopefully easier to read and remove this specific issue. I couldn't find a nice way to do an or to remove the duplication so we end up with some (ugly) replication of the flags.

@vmcj vmcj force-pushed the quiet_sh_script_fix branch from 5ad0828 to 73f2a88 Compare December 29, 2025 18:09
@vmcj vmcj requested a review from eldering December 29, 2025 18:15
Copy link
Copy Markdown
Member

@eldering eldering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with adding QUIET_FLAG{,_CAPITAL}, but I think right now the difference (if any?) between specifying QUIET=0 or nothing is unclear.
I'd rather not have that difference at all, or if really necessary clearly document why/where that's needed.

@vmcj
Copy link
Copy Markdown
Member Author

vmcj commented Mar 21, 2026

I'm fine with adding QUIET_FLAG{,_CAPITAL}, but I think right now the difference (if any?) between specifying QUIET=0 or nothing is unclear. I'd rather not have that difference at all, or if really necessary clearly document why/where that's needed.

I was debugging the demoweb instance, where we have QUIET=1 in the scripts. As not all files are versioncontrolled I rather change the QUIET=1 to QUIET=0 as that way I can easily check where I should fix the option again after I was done on the demoweb fixing.

So I propose that we have:

Verbose:
QUIET=
QUIET=0

Quiet:
QUIET=1...

Which I think all reflect normal boolean rules and feel intuitive to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants