enables edge rendering using Freestyle, save edges with bop writer#1203
Open
maivnov wants to merge 5 commits intoDLR-RM:mainfrom
Open
enables edge rendering using Freestyle, save edges with bop writer#1203maivnov wants to merge 5 commits intoDLR-RM:mainfrom
maivnov wants to merge 5 commits intoDLR-RM:mainfrom
Conversation
Member
|
Thanks @maivnov, is there an easy way to undo the formatting? This makes the review a lot harder and I would rather stay with our current coding style. |
Author
|
I changed my formatting to your style and also added some fixes for Windows paths, since some parts of the code are hardcoded for Linux. I also updated the |
Member
6be9791 to
0525d04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Proposal to extend the pipeline with Freestyle edge rendering of target objects in the scene and save the edge renders using the
writer_bop. An example using the T-LESS dataset is provided inmain_tless_randomAll files were auto formatted using the black extension.