Skip to content

feat: Flexible commits#125

Merged
sunib merged 30 commits intomainfrom
sign
Apr 17, 2026
Merged

feat: Flexible commits#125
sunib merged 30 commits intomainfrom
sign

Conversation

@sunib
Copy link
Copy Markdown
Contributor

@sunib sunib commented Apr 10, 2026

Extending how commits are made: you can configure author, and committer. And you now can set a template for the commit messages.

It's also possible to sign your commits automatically, which gives you the option to have a trustworthy audit. If you combine it with a mutually signed kubernetes-api-audit-webhook configuration (docs need some love on this, but e2e tests already show how to do it).

Also improved general things like Makefile (replaced it with Taskfiles) and e2e architecture (more clarity on what is defined on what level).

@kilo-code-bot
Copy link
Copy Markdown

kilo-code-bot Bot commented Apr 10, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Incremental Changes (since last review)

File Change
Tiltfile Updated - Now auto-bootstraps cluster, adds playground resources
test/e2e/Taskfile.yml Added - Tilt playground tasks
test/e2e/tilt_playground_e2e_test.go New - E2E tests for playground
test/playground/ New - Playground manifests (configmap, gitprovider, etc.)
test/e2e/tools/playground-cleanup/ New - Cleanup tool
internal/giteaclient/keys.go New - Key management methods
internal/giteaclient/keys_test.go New - Tests for key management
docs/design/tilt-playground-plan.md New - Design document

Tilt Playground Feature

The Tiltfile now includes a "playground" for manual testing and exploration:

New workflow:

  1. Run tilt up - automatically bootstraps the e2e cluster
  2. Playground resources are loaded from test/playground/

Playground resources:

  • test/playground/configmap.yaml - Sample ConfigMap to trigger changes
  • test/playground/gitprovider.yaml - GitProvider pointing to test repo
  • test/playground/gittarget.yaml - GitTarget defining branch/path
  • test/playground/watchrule.yaml - WatchRule for ConfigMaps

New e2e test: tilt_playground_e2e_test.go - Tests the playground setup

New cleanup tool: test/e2e/tools/playground-cleanup/ - Cleans up playground resources

Additional: internal/giteaclient/keys.go - Added key management methods with tests

Files Reviewed (19 files)
  • Tiltfile and playground setup
  • New e2e tests
  • Key management in giteaclient

Reviewed by minimax-m2.5-20260211 · 20,781 tokens

@sunib sunib merged commit 1513620 into main Apr 17, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant