Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Incremental Changes (since last review)
Tilt Playground FeatureThe Tiltfile now includes a "playground" for manual testing and exploration: New workflow:
Playground resources:
New e2e test: New cleanup tool: Additional: Files Reviewed (19 files)
Reviewed by minimax-m2.5-20260211 · 20,781 tokens |
…t block, just give a good error).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extending how commits are made: you can configure author, and committer. And you now can set a template for the commit messages.
It's also possible to sign your commits automatically, which gives you the option to have a trustworthy audit. If you combine it with a mutually signed kubernetes-api-audit-webhook configuration (docs need some love on this, but e2e tests already show how to do it).
Also improved general things like Makefile (replaced it with Taskfiles) and e2e architecture (more clarity on what is defined on what level).