feat(tutorinsa): replace tutorinsa link by instagram account#132
feat(tutorinsa): replace tutorinsa link by instagram account#132ignyx merged 3 commits intoClubInfoInsaT:masterfrom
Conversation
ignyx
left a comment
ignyx
left a comment
There was a problem hiding this comment.
Looks good to me ! In some cases linking to the https:// url might be enough to open the Instagram app, but will work just fine 👍
I will need to test on an iOS device.
Please run npm run lint-fix
|
Yes I added the deep link so that phones don't go on the navigator to then redirect to the app but directly goes to Instagram. Yes I couldn't run a test on iOS as I can't build it. I'll run the fix asap |
|
I've ran lint-fix and tested it on android. FYI, I also changed the prettier eof in package but did not double-commited it |
pierrbt
changed the title
|
I have rebased, lint-fix is up to date. Ready to merge if you're ok ! |
|
FYI: I had to modify gitignore again, because on Windows, build files built in android/app/.cxx, so I added it to gitignore, hoping it wont cause troubles. |
ignyx
left a comment
ignyx
left a comment
There was a problem hiding this comment.
build files built in android/app/.cxx
After the rebase on main, this should no longer be an issue (I recently added .cxx/ to the gitignore). I dropped the commit adding android/app/.cxx/. Let me know if this issue persists.
Thanks for patching this, let get this to prod 🎉
2 participants
I have changed the link of tutorinsa, it now automatically show the instagram account, or insta website if not installed. This PR closes #126