GQSP-Based Hamiltonian Simulation for the Hubbard-Holstein Model — Paper Implementation Challenge#1524
GQSP-Based Hamiltonian Simulation for the Hubbard-Holstein Model — Paper Implementation Challenge#1524achebiyam wants to merge 7 commits intoClassiq:mainfrom
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
🔥 New notebook just dropped! @amir-naveh , @TomerGoldfriend — come check out this shiny new addition to our repo. |
|
Note: The .qmod export fails due to a serialization issue in lcu_pauli (TypeError: 'CParamScalar' object cannot be interpreted as an integer). This appears to be an SDK bug in write_qmod when used with lcu_pauli. The synthesized circuit is viewable on the Classiq platform here: https://platform.classiq.io/circuit/3B1F4EOqyt9Dqwju9Ik37lJQvc4 Happy to add the .qmod file once this serialization issue is resolved, or if the team can suggest a workaround. |
Thank you @achebiyam , I will go over the PR. I will pass this bug to the team. There is no need to include .qmod anymore, so you can delete it and the |
Thanks @TomerGoldfriend! The submitted notebook already uses show(qprog_gqsp) |
| @@ -0,0 +1,1243 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #1. !pip install "classiq[qsp]" keyrings.alt pennylane -q
remove any pennylane use from the notebook
Reply via ReviewNB
| @@ -0,0 +1,1243 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,1243 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #2. classiq.authenticate()
remove authentication from the notebook. It is a pre assumption for the notebook
Reply via ReviewNB
|
Done. I removed pennylane, keyring, and authenticate. Also removed the VQE section which depended on pennylane. Happy to address any further feedback. |
|
@achebiyam |
|
I appreciate the feedback. This notebook represents several weeks of original research, including diagnosing a previously unreported platform limitation at exactly 16 Pauli terms and implementing the first GQSP simulation of an electron-phonon system on Classiq. I used AI tooling for polish and presentation, not for the research or implementation itself. That said, I do understand the style doesn't match the existing notebooks in the repo. I'll rework the markdown and formatting to better align with your conventions and resubmit. Thanks again. |
…holstein_gqsp.ipynb
Rework notebook style per reviewer feedback
|
Hi @orsa-classiq, @TomerGoldfriend, just checking in on this PR. I addressed all the feedback from late March (removed pennylane/keyring/authenticate, reworked the markdown style and tone to match the existing notebooks in the repo). Happy to make any additional changes if there's anything else you'd like adjusted. Thanks! |
OK @achebiyam, I will examine it. Sorry for missing your last commits and thanks for the reminder. |
Paper Implementation Challenge Submission
GitHub Issue: #1504
Author: @achebiyam
Summary
First application of Generalized Quantum Signal Processing (GQSP) to an
electron-phonon coupled system (Hubbard-Holstein model) on the Classiq platform.
What's included
Primary reference
D. Motlagh and N. Wiebe, "Generalized Quantum Signal Processing",
PRX Quantum 5, 020368 (2024). arXiv:2308.01501
Notes
pip install "classiq[qsp]"