Conversation
tneotia
left a comment
There was a problem hiding this comment.
So far nothing super major. The only thing I will add here thats overarching is that I think it would be awesome if rather than checking getRemoteService for things that RustPush can't do, is that the backend has actual getters to check for these things. For example backend.canFetchGroupChatIcon. Not saying we will ever become a matrix client, but if someone wants to integrate another backend, its quite possible that it has a remote service but that isn't a thing for them. Just food for thought, I know itll be a bit more work but I think that would be nice.
|
what happened with all this |
Tae decided to release it as OpenBubbles and this is just the beginnings of that. Since he doesn't plan to merge OpenBubbles into BlueBubbles, there is no real reason to merge |
|
I feel like this is just a little cleaner though no? For sure up to you but I do think there is merit also I do see you ending up doing some of this in the future tbh |
|
Then close ? |
New and improved abstractions!