Fix: Ensure TransformComponent Handles Conditional Rendering Gracefully#520
Open
mhryshkin wants to merge 1 commit intoBetterTyped:masterfrom
Open
Fix: Ensure TransformComponent Handles Conditional Rendering Gracefully#520mhryshkin wants to merge 1 commit intoBetterTyped:masterfrom
mhryshkin wants to merge 1 commit intoBetterTyped:masterfrom
Conversation
morishjs
reviewed
Dec 19, 2024
|
|
||
| if (!wrapperComponent || !contentComponent) { | ||
| throw new Error("Components are not mounted"); | ||
| return { |
There was a problem hiding this comment.
Unfortunately, this causes resetTransform to not work
Author
There was a problem hiding this comment.
How exactly? I mean this change should affect anything only at first render time to prevent this component throwing an error in case of a delayed render of a children.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #516, addressing an error where components are not mounted when
TransformComponentis rendered conditionally or delayed.Changes: