Fix: Only show domain-only thank you page for actual domain-only flows#109999
Open
Fix: Only show domain-only thank you page for actual domain-only flows#109999
Conversation
Add check for domainOnlySiteFlow prop to ensure the DomainOnly component is only rendered for actual domain-only purchases, not for domain purchases on existing sites. This fixes a regression introduced in commit ac75c80 which removed the feature flag check that previously distinguished between: - Domain-only flows (needs special thank-you page with site creation options) - Domain purchases on existing sites (needs appropriate page for adding domain) When the feature flag was removed, the code lost the ability to distinguish between these two cases, causing all domain purchases to show the domain-only options page regardless of whether they were actually domain-only.
Jetpack Cloud Live (direct link)
Automattic for Agencies Live (direct link)
Dashboard Live (dotcom) (direct link)
|
matticbot
added
the
[Status] Needs Review
Contributor
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Ensures the DomainOnly page is only rendered when both isOnlyDomainPurchases and domainOnlySiteFlow are true, preventing the page from incorrectly appearing in non-domain-only flows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://linear.app/a8c/issue/CHE-472/regression-post-checkout-thank-you-page-for-a-domain-purchased-on-an
Summary
Fixes a regression where domain purchases on existing sites were incorrectly showing the domain-only thank-you page with options like "Start a new site", "Add a mailbox", "Attach to an existing site", etc.
Problem
When a user purchases a domain for an existing site (e.g., from
wordpress.com/domains/add/[site]), the thank-you page was displaying domain-only options instead of an appropriate page for adding a domain to an existing site.Root Cause
Commit ac75c80c6a4 (Feb 19, 2026) removed a feature flag check that distinguished between:
DomainOnlycomponent with site creation optionsWhen the feature flag was removed, the code lost the ability to distinguish between these cases, causing ALL domain purchases to show the domain-only page.
The Fix
Added
this.props.domainOnlySiteFlowcheck to the condition that renders theDomainOnlycomponent:Now the domain-only thank-you page is only shown for actual domain-only flows, allowing other domain purchases to fall through to appropriate thank-you page components.
Test Plan
wordpress.com/domains/add/[site])