Design: Replace plan card icon with dashboard icon for Commerce Garden#109977
Draft
Design: Replace plan card icon with dashboard icon for Commerce Garden#109977
Conversation
…n sites Swap the Commerce Garden plan card icon from the previous steps/checklist SVG to the dashboard (speedometer) icon. Also fixes the viewBox from 25x24 to 24x24 and uses currentColor instead of hardcoded fill for theme support.
Jetpack Cloud Live (direct link)
Automattic for Agencies Live (direct link)
Dashboard Live (dotcom) (direct link)
|
The previous icon was a stair/steps shape. Rename the export to reflect the new dashboard icon it now contains.
Contributor
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Author
Before / AfterBefore: After: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
commerceGardenPlantocommerceGardenDashboardto reflect the new iconcurrentColorinstead of hardcoded#1E1E1Efill for proper theme color supportWhy are these changes being made?
The dashboard icon is already used in the CIAB pre-launch checklist to represent plans. This change brings the site overview plan card in line with that pattern, keeping the icon language consistent across CIAB MSD — anywhere we reference plans in the CIAB dashboard should use the dashboard icon.
The dashboard icon exists in
@wordpress/icons(visible in the Gutenberg Storybook), but wp-calypso currently uses v10.23.0 which does not include it yet (it was added in a later version). Rather than upgrading the package dependency, we added the SVG directly as a custom icon inclient/dashboard/components/icons/— this follows the existing pattern used by other custom icons in the same file (launch,upsell).Testing Instructions
yarn start-dashboardhttp://my.woo.localhost:3000/Pre-merge Checklist