Subscribers: fix layout gap and add SidebarNavigation on JP Cloud#109971
Open
Subscribers: fix layout gap and add SidebarNavigation on JP Cloud#109971
Conversation
Remove extra padding on .layout__content that created a visible gap around the Subscribers DataViews table. Simplify padding to match the masterbar/sidebar boundaries directly. Switch <Main> from wideLayout to fullWidthLayout so the page fills the content area. Add <SidebarNavigation /> on JP Cloud so mobile users have the hamburger menu to navigate away. Also replace the hardcoded 62px padding-top in the sidebar focus-content rule with var(--masterbar-height, 62px) for consistency. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Jetpack Cloud Live (direct link)
Automattic for Agencies Live (direct link)
Dashboard Live (dotcom) (direct link)
|
Contributor
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of JETPACK-1513
Proposed Changes
.layout__contentthat created a visible gap around the Subscribers DataViews table. Simplify padding to match the masterbar/sidebar boundaries directly.<Main>fromwideLayouttofullWidthLayoutso the page fills the content area.<SidebarNavigation />on JP Cloud so mobile users have the hamburger menu to navigate away (was missing — same navigation trap as Earn/Social).62pxpadding-top in the sidebar focus-content rule withvar(--masterbar-height, 62px)for consistency.Why are these changes being made?
The Subscribers page on Calypso had a visible gap between the content area and the sidebar/masterbar boundaries, caused by extra padding in
.layout__content. This was inconsistent with other Jetpack admin pages that sit flush against the layout edges.On JP Cloud mobile, the Subscribers page was missing
<SidebarNavigation />— the same navigation trap we fixed on Earn and Social in #109899. Without the hamburger menu, users had no way to navigate away from the page on mobile.Testing Instructions
Calypso (WP.com):
/subscribers/<site-slug>JP Cloud:
/subscribers/<site-slug>on cloud.jetpack.comBefore / after
Calypso Desktop — gap removed
Content now sits flush against sidebar and masterbar. No extra padding gap.
Calypso Mobile
JP Cloud Desktop
JP Cloud Mobile — navigation trap fixed
Before: no hamburger menu, no way to navigate out. After: hamburger + site title present.
Pre-merge Checklist