Skip to content

fix: send server discovery logs to stderr to avoid corrupting MCP stdout on Windows #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pntgoswami18 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: send server discovery logs to stderr to avoid corrupting MCP stdout on Windows #222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions browser-tools-mcp/mcp-server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ function getDefaultServerHost(): string {

// Server discovery function - similar to what you have in the Chrome extension
async function discoverServer(): Promise<boolean> {
console.log("Starting server discovery process");
console.error("Starting server discovery process");

// Common hosts to try
const hosts = [getDefaultServerHost(), "127.0.0.1", "localhost"];
Expand All @@ -72,14 +72,14 @@ async function discoverServer(): Promise<boolean> {
}
}

console.log(`Will try hosts: ${hosts.join(", ")}`);
console.log(`Will try ports: ${ports.join(", ")}`);
console.error(`Will try hosts: ${hosts.join(", ")}`);
console.error(`Will try ports: ${ports.join(", ")}`);

// Try to find the server
for (const host of hosts) {
for (const port of ports) {
try {
console.log(`Checking ${host}:${port}...`);
console.error(`Checking ${host}:${port}...`);

// Use the identity endpoint for validation
const response = await fetch(`http://${host}:${port}/.identity`, {
Expand All @@ -91,7 +91,7 @@ async function discoverServer(): Promise<boolean> {

// Verify this is actually our server by checking the signature
if (identity.signature === "mcp-browser-connector-24x7") {
console.log(`Successfully found server at ${host}:${port}`);
console.error(`Successfully found server at ${host}:${port}`);

// Save the discovered connection
discoveredHost = host;
Expand Down Expand Up @@ -357,7 +357,7 @@ server.tool(
return await withServerConnection(async () => {
try {
// Simplified approach - let the browser connector handle the current tab and URL
console.log(
console.error(
`Sending POST request to http://${discoveredHost}:${discoveredPort}/accessibility-audit`
);
const response = await fetch(
Expand All @@ -377,7 +377,7 @@ server.tool(
);

// Log the response status
console.log(`Accessibility audit response status: ${response.status}`);
console.error(`Accessibility audit response status: ${response.status}`);

if (!response.ok) {
const errorText = await response.text();
Expand Down Expand Up @@ -440,7 +440,7 @@ server.tool(
return await withServerConnection(async () => {
try {
// Simplified approach - let the browser connector handle the current tab and URL
console.log(
console.error(
`Sending POST request to http://${discoveredHost}:${discoveredPort}/performance-audit`
);
const response = await fetch(
Expand All @@ -460,7 +460,7 @@ server.tool(
);

// Log the response status
console.log(`Performance audit response status: ${response.status}`);
console.error(`Performance audit response status: ${response.status}`);

if (!response.ok) {
const errorText = await response.text();
Expand Down Expand Up @@ -522,7 +522,7 @@ server.tool(
async () => {
return await withServerConnection(async () => {
try {
console.log(
console.error(
`Sending POST request to http://${discoveredHost}:${discoveredPort}/seo-audit`
);
const response = await fetch(
Expand All @@ -542,7 +542,7 @@ server.tool(
);

// Log the response status
console.log(`SEO audit response status: ${response.status}`);
console.error(`SEO audit response status: ${response.status}`);

if (!response.ok) {
const errorText = await response.text();
Expand Down Expand Up @@ -1354,7 +1354,7 @@ server.tool(
async () => {
return await withServerConnection(async () => {
try {
console.log(
console.error(
`Sending POST request to http://${discoveredHost}:${discoveredPort}/best-practices-audit`
);
const response = await fetch(
Expand Down