Skip to content

refactor: approval flow status permission#2085

Merged
fit2-zhao merged 1 commit intomainfrom
pr@main@refactor_approval_status_permission
Apr 22, 2026
Merged

refactor: approval flow status permission#2085
fit2-zhao merged 1 commit intomainfrom
pr@main@refactor_approval_status_permission

Conversation

@fit2-zhao
Copy link
Copy Markdown
Member

refactor: approval flow status permission

@f2c-ci-robot
Copy link
Copy Markdown

f2c-ci-robot Bot commented Apr 22, 2026

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot
Copy link
Copy Markdown

f2c-ci-robot Bot commented Apr 22, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fit2cloudwxx for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

❌ Patch coverage is 0% with 55 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.80%. Comparing base (0f4453b) to head (5b69f5b).
⚠️ Report is 464 commits behind head on main.

Files with missing lines Patch % Lines
...rdys/crm/approval/service/ApprovalFlowService.java 0.00% 48 Missing ⚠️
...s/crm/approval/constants/ApprovalFormTypeEnum.java 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2085      +/-   ##
============================================
- Coverage     33.29%   32.80%   -0.49%     
- Complexity     1946     2087     +141     
============================================
  Files           382      408      +26     
  Lines         21892    23769    +1877     
  Branches       2309     2511     +202     
============================================
+ Hits           7289     7798     +509     
- Misses        14042    15366    +1324     
- Partials        561      605      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fit2-zhao fit2-zhao merged commit 5f7ca59 into main Apr 22, 2026
5 of 8 checks passed
@fit2-zhao fit2-zhao deleted the pr@main@refactor_approval_status_permission branch April 22, 2026 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants