Skip to content

Commit 140cd5e

Browse files
yonaskolbclaude
andauthored
Fix CI: add explicit xcodebuild destinations and update Xcode matrix (#1594)
- Add explicit -destination flags to build.sh — newer Xcode versions no longer auto-select a build destination, causing "Found no destinations for the scheme" errors - Update CI matrix to Xcode 16.4 and 26.2 — Xcode 16.0-16.3 simulator runtimes are no longer installed on the macos-15 runner image - Add PRODUCT_BUNDLE_IDENTIFIER to ExternalTarget fixture — Xcode 26.x requires a bundle identifier for embedded frameworks Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
1 parent d35562f commit 140cd5e

5 files changed

Lines changed: 16 additions & 9 deletions

File tree

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ jobs:
88
name: Xcode ${{ matrix.xcode }}
99
strategy:
1010
matrix:
11-
xcode: ["16.0", "16.3"]
11+
xcode: ["16.4", "26.2"]
1212
env:
1313
DEVELOPER_DIR: /Applications/Xcode_${{ matrix.xcode }}.app/Contents/Developer
1414
steps:

Tests/Fixtures/TestProject/AnotherProject/AnotherProject.xcodeproj/project.pbxproj

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -342,6 +342,7 @@
342342
"$(inherited)",
343343
"@executable_path/Frameworks",
344344
);
345+
PRODUCT_BUNDLE_IDENTIFIER = com.project.external;
345346
SDKROOT = iphoneos;
346347
SKIP_INSTALL = YES;
347348
TARGETED_DEVICE_FAMILY = "1,2";
@@ -452,6 +453,7 @@
452453
"$(inherited)",
453454
"@executable_path/Frameworks",
454455
);
456+
PRODUCT_BUNDLE_IDENTIFIER = com.project.external;
455457
SDKROOT = iphoneos;
456458
SKIP_INSTALL = YES;
457459
TARGETED_DEVICE_FAMILY = "1,2";
@@ -474,6 +476,7 @@
474476
"$(inherited)",
475477
"@executable_path/Frameworks",
476478
);
479+
PRODUCT_BUNDLE_IDENTIFIER = com.project.external;
477480
SDKROOT = iphoneos;
478481
SKIP_INSTALL = YES;
479482
TARGETED_DEVICE_FAMILY = "1,2";
@@ -496,6 +499,7 @@
496499
"$(inherited)",
497500
"@executable_path/Frameworks",
498501
);
502+
PRODUCT_BUNDLE_IDENTIFIER = com.project.external;
499503
SDKROOT = iphoneos;
500504
SKIP_INSTALL = YES;
501505
TARGETED_DEVICE_FAMILY = "1,2";
@@ -657,6 +661,7 @@
657661
"$(inherited)",
658662
"@executable_path/Frameworks",
659663
);
664+
PRODUCT_BUNDLE_IDENTIFIER = com.project.external;
660665
SDKROOT = iphoneos;
661666
SKIP_INSTALL = YES;
662667
TARGETED_DEVICE_FAMILY = "1,2";
@@ -703,6 +708,7 @@
703708
"$(inherited)",
704709
"@executable_path/Frameworks",
705710
);
711+
PRODUCT_BUNDLE_IDENTIFIER = com.project.external;
706712
SDKROOT = iphoneos;
707713
SKIP_INSTALL = YES;
708714
TARGETED_DEVICE_FAMILY = "1,2";

Tests/Fixtures/TestProject/AnotherProject/project.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ targets:
2020
platform: iOS
2121
settings:
2222
GENERATE_INFOPLIST_FILE: YES
23+
PRODUCT_BUNDLE_IDENTIFIER: com.project.external
2324
IncludedLegacy:
2425
type: ""
2526
platform: iOS

Tests/Fixtures/TestProject/Project.xcodeproj/project.pbxproj

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3522,7 +3522,7 @@
35223522
"$(inherited)",
35233523
"@executable_path/Frameworks",
35243524
);
3525-
PRODUCT_BUNDLE_IDENTIFIER = com.project.ExternalTarget;
3525+
PRODUCT_BUNDLE_IDENTIFIER = com.project.external;
35263526
SDKROOT = iphoneos;
35273527
SKIP_INSTALL = YES;
35283528
TARGETED_DEVICE_FAMILY = "1,2";
@@ -4220,7 +4220,7 @@
42204220
"$(inherited)",
42214221
"@executable_path/Frameworks",
42224222
);
4223-
PRODUCT_BUNDLE_IDENTIFIER = com.project.ExternalTarget;
4223+
PRODUCT_BUNDLE_IDENTIFIER = com.project.external;
42244224
SDKROOT = iphoneos;
42254225
SKIP_INSTALL = YES;
42264226
TARGETED_DEVICE_FAMILY = "1,2";
@@ -6058,7 +6058,7 @@
60586058
"$(inherited)",
60596059
"@executable_path/Frameworks",
60606060
);
6061-
PRODUCT_BUNDLE_IDENTIFIER = com.project.ExternalTarget;
6061+
PRODUCT_BUNDLE_IDENTIFIER = com.project.external;
60626062
SDKROOT = iphoneos;
60636063
SKIP_INSTALL = YES;
60646064
TARGETED_DEVICE_FAMILY = "1,2";
@@ -6655,7 +6655,7 @@
66556655
"$(inherited)",
66566656
"@executable_path/Frameworks",
66576657
);
6658-
PRODUCT_BUNDLE_IDENTIFIER = com.project.ExternalTarget;
6658+
PRODUCT_BUNDLE_IDENTIFIER = com.project.external;
66596659
SDKROOT = iphoneos;
66606660
SKIP_INSTALL = YES;
66616661
TARGETED_DEVICE_FAMILY = "1,2";
@@ -6856,7 +6856,7 @@
68566856
"$(inherited)",
68576857
"@executable_path/Frameworks",
68586858
);
6859-
PRODUCT_BUNDLE_IDENTIFIER = com.project.ExternalTarget;
6859+
PRODUCT_BUNDLE_IDENTIFIER = com.project.external;
68606860
SDKROOT = iphoneos;
68616861
SKIP_INSTALL = YES;
68626862
TARGETED_DEVICE_FAMILY = "1,2";
@@ -7259,7 +7259,7 @@
72597259
"$(inherited)",
72607260
"@executable_path/Frameworks",
72617261
);
7262-
PRODUCT_BUNDLE_IDENTIFIER = com.project.ExternalTarget;
7262+
PRODUCT_BUNDLE_IDENTIFIER = com.project.external;
72637263
SDKROOT = iphoneos;
72647264
SKIP_INSTALL = YES;
72657265
TARGETED_DEVICE_FAMILY = "1,2";

Tests/Fixtures/TestProject/build.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@ set -e
33

44
echo "
55
⚙️ Building iOS app"
6-
xcodebuild -quiet -workspace Workspace.xcworkspace -scheme "App_iOS Test" -configuration "Test Debug" -xcconfig fixtures.xcconfig
6+
xcodebuild -quiet -workspace Workspace.xcworkspace -scheme "App_iOS Test" -configuration "Test Debug" -xcconfig fixtures.xcconfig -destination 'generic/platform=iOS Simulator'
77
echo "✅ Successfully built iOS app"
88

99
echo "
1010
⚙️ Building macOS app"
11-
xcodebuild -quiet -workspace Workspace.xcworkspace -scheme "App_macOS" -configuration "Test Debug" -xcconfig fixtures.xcconfig
11+
xcodebuild -quiet -workspace Workspace.xcworkspace -scheme "App_macOS" -configuration "Test Debug" -xcconfig fixtures.xcconfig -destination 'generic/platform=macOS'
1212
echo "✅ Successfully built macOS app"

0 commit comments

Comments
 (0)