Skip to content

Do not update image on UI if the downloading task is cancelled#25501

Open
crazytonyli wants to merge 3 commits intotrunkfrom
bugfix/incorrect-notification-avatar
Open

Do not update image on UI if the downloading task is cancelled#25501
crazytonyli wants to merge 3 commits intotrunkfrom
bugfix/incorrect-notification-avatar

Conversation

@crazytonyli
Copy link
Copy Markdown
Contributor

Description

The first commit contains the core change, which skips updating the UI if the fetching image task was canceled.

@crazytonyli crazytonyli added this to the 26.9 milestone Apr 21, 2026
@crazytonyli crazytonyli requested a review from jkmassel April 21, 2026 06:36
@dangermattic
Copy link
Copy Markdown
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 26.9. This milestone is due in less than 4 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@crazytonyli crazytonyli changed the title Bugfix/incorrect notification avatar Do not update image on UI if the downloading task is cancelled Apr 21, 2026
@wpmobilebot
Copy link
Copy Markdown
Contributor

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number32033
VersionPR #25501
Bundle IDorg.wordpress.alpha
Commit2341d08
Installation URL16jn6hm4p8cm8
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Copy Markdown
Contributor

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number32033
VersionPR #25501
Bundle IDcom.jetpack.alpha
Commit2341d08
Installation URL2nibjsrcidnm8
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

Copy link
Copy Markdown
Contributor

@jkmassel jkmassel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems worth a try

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants