Fix Windows CI test failure for test_network_from_json

Use delete_on_close=False for NamedTemporaryFile to allow reopening
the file by name on Windows, which has exclusive file locking.

Also remove continue-on-error for Windows now that the issue is fixed.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: wmayner

.github/workflows/test.yml

@@ -34,7 +34,6 @@ jobs:
       - name: Run tests
         if: ${{ !(matrix.os == 'ubuntu-latest' && matrix.python-version == '3.12') }}
         run: uv run pytest test/ --tb=short -v --ignore=test/test_parallel.py --ignore=test/test_parallel2.py
-        continue-on-error: ${{ matrix.os == 'windows-latest' }}
 
       - name: Run tests with coverage
         if: matrix.os == 'ubuntu-latest' && matrix.python-version == '3.12'

test/test_json.py

@@ -99,7 +99,9 @@ def test_deserialization_memoizes_duplicate_objects(s):
 
 @pytest.fixture
 def network_file(standard):
-    with tempfile.NamedTemporaryFile(mode="w+") as f:
+    # delete_on_close=False allows reopening the file by name on Windows
+    # (Windows doesn't allow opening a file that's already open)
+    with tempfile.NamedTemporaryFile(mode="w+", delete_on_close=False) as f:
         jsonify.dump(standard, f)
         f.seek(0)
         yield f