(Twoslash) Compilation errors are silent and cause entire file to fail to render

[ethanniser]

Thank you for making this package- it is super useful

However I find it really hard to use as if there is any sort of compilation error, nothing is logged out and the entire page I'm working on immediately goes blank

I would except some kind of error message to help debug the issue, as well as for this to prevent builds from successfully completing

Reproduction Steps

1. Clone https://github.com/ethanniser/ec-twoslash-issue-repro.git
2. Run bun i then bun run dev
3. Go to http://localhost:4321/blog/example/
4. Observe twoslash working
5. Uncomment commented lines in src/content/blog/example.md
6. Observe whole page go blank
7. Run bun run build
8. Observe build succeed without error
9. Look at dist and see that build output is also blank (like dev)

[ethanniser]

https://twoslash.matthiesen.dev/usage/banners/errors/

for this for example you cant see what the error number is easily

[Adammatthiesen]

Sorry about the delay, apparently notifications are not working correctly for me

For the Errors to be displayed correctly it only works in dev mode atm, see this example which is how i usually get the error codes to put into the // @errors setting...

Sadly The way twoslash throws the errors i have yet to find a way to gracefully throw a nicer error using specifically the Astro error and display only the needed info... this is mainly due to the interactions between EC/Twoslash/Astro and how each handle errors slightly different. BUT in most cases, even when i build using my server i do see errors with the codes being surfaced... so im not really sure why it wouldn't be working.

I also see your using bun, Astro does not officially support bun, so that could also be part of why errors would not be properly surfaced.

Message from Astro docs:
Using Bun with Astro may reveal rough edges. Some integrations may not work as expected. Consult Bun’s official documentation for working with Astro for details.

If you have any problems using Bun, please open an Issue on GitHub with Bun directly.

If you could please try with npm or pnpm that would be a better test instead of bun.

[ethanniser]

Thanks for the response

I see the compilation error in the dev/build output, but the build still succeeds successfully...

I want (need?) the build to fail if a page fails to render

Is this just not something astro supports?

[Adammatthiesen]

@ethanniser Weird, on my deployments (from either a self-hosted coolify or netlify using pnpm) it does indeed kill the build process if there is an error 🤔 (unless i explicitly allow an error by adding to the noError array)...

For reference, here is the repo I mainly have EC-Twoslash used in https://github.com/withstudiocms/docs where i have it configured in the ec.config.mjs (had to allow some errors due to our i18n setup and having translators who update the other langs on not myself)