Skip to content
This repository was archived by the owner on Nov 17, 2021. It is now read-only.
This repository was archived by the owner on Nov 17, 2021. It is now read-only.

diff subcommand should ignore gc tag #316

@kgtw

Description

@kgtw

We run the diff subcommand during CI process involved with PR reviews, which comments back the diff as a PR comment in github.

When this happens we are getting false/positives because in some cases the only difference is the gc tag.

"metadata": {
-      "annotations": {
-       "kubecfg.ksonnet.io/garbage-collect-tag": "my-service",
-      },
-      "labels": {
-       "kubecfg.ksonnet.io/garbage-collect-tag": "my-service",
-      },

Either the diff subcommand should ignore the gc tag entirely, or the option to provide it should be made available to avoid such instances of this happening.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions