Skip to content
This repository was archived by the owner on Nov 17, 2021. It is now read-only.

Commit c79d627

Browse files
author
Marko Mikulicic
authored
Merge pull request #272 from Catalysts/validate-name
validate if name is set
2 parents 16949d6 + 116777e commit c79d627

2 files changed

Lines changed: 7 additions & 0 deletions

File tree

pkg/kubecfg/diff.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,10 @@ func (c DiffCmd) Run(apiObjects []*unstructured.Unstructured, out io.Writer) err
6767
return err
6868
}
6969

70+
if obj.GetName() == "" {
71+
return fmt.Errorf("Error fetching one of the %s: it does not have a name set", utils.ResourceNameFor(c.Mapper, obj))
72+
}
73+
7074
liveObj, err := client.Get(obj.GetName(), metav1.GetOptions{})
7175
if err != nil && errors.IsNotFound(err) {
7276
log.Debugf("%s doesn't exist on the server", desc)

pkg/kubecfg/validate.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,9 @@ func (c ValidateCmd) Run(apiObjects []*unstructured.Unstructured, out io.Writer)
8282
for _, err := range schema.Validate(obj) {
8383
allErrs = append(allErrs, err)
8484
}
85+
if obj.GetName() == "" {
86+
allErrs = append(allErrs, fmt.Errorf("An Object does not have a name set"))
87+
}
8588
}
8689

8790
for _, err := range allErrs {

0 commit comments

Comments
 (0)