Set MinGOP in bitmovin preset when GopMode is fixed (#331)

esonderegger · Evan Sonderegger · adamthesax · web-flow · commit 4da72b8f80bf · 2020-10-22T14:21:39.000-04:00
* Set MinGOP in bitmovin preset when GopMode is fixed

* disable scenecut when in fixed GOP mode

Co-authored-by: Evan Sonderegger &lt;evan.sonderegger@nytimes.comm&gt;
Co-authored-by: Adam Sax &lt;adam.sax@nytimes.com&gt;
diff --git a/internal/provider/bitmovin/bitmovin.go b/internal/provider/bitmovin/bitmovin.go
@@ -227,6 +227,10 @@ func (p *bitmovinProvider) createH264VideoPreset(preset db.Preset, customData ma
 			return nil, err
 		}
 		h264.MaxGOP = intToPtr(int64(gopSize))
+		if preset.Video.GopMode == "fixed" {
+			h264.MinGOP = intToPtr(int64(gopSize))
+			h264.SceneCutThreshold = intToPtr(int64(0))
+		}
 	}
 	if preset.Video.BFrames != "" {
 		bFrames, err := strconv.Atoi(preset.Video.BFrames)

Original file line number	Diff line number	Diff line change
`@@ -227,6 +227,10 @@ func (p *bitmovinProvider) createH264VideoPreset(preset db.Preset, customData ma`
`227`	`227`	`return nil, err`
`228`	`228`	`}`
`229`	`229`	`h264.MaxGOP = intToPtr(int64(gopSize))`
	`230`	`+ if preset.Video.GopMode == "fixed" {`
	`231`	`+ h264.MinGOP = intToPtr(int64(gopSize))`
	`232`	`+ h264.SceneCutThreshold = intToPtr(int64(0))`
	`233`	`+ }`
`230`	`234`	`}`
`231`	`235`	`if preset.Video.BFrames != "" {`
`232`	`236`	`bFrames, err := strconv.Atoi(preset.Video.BFrames)`