Skip to content

Commit 8a4eb9d

Browse files
committed
Update Jackson serialization classes and dependencies
Replace deprecated Jackson2JsonMessageConverter with JacksonJsonMessageConverter in AMQP configurations. Update Jackson dependencies from com.fasterxml.jackson to tools.jackson namespace. Fix KafkaItemWriterAutoConfiguration to use proper import and remove misplaced file from resources directory.
1 parent 4473501 commit 8a4eb9d

File tree

9 files changed

+23
-32
lines changed

9 files changed

+23
-32
lines changed

spring-cloud-starter-single-step-batch-job/pom.xml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -77,12 +77,12 @@
7777
<scope>test</scope>
7878
</dependency>
7979
<dependency>
80-
<groupId>com.fasterxml.jackson.core</groupId>
81-
<artifactId>jackson-databind</artifactId>
80+
<groupId>tools.jackson.core</groupId>
81+
<artifactId>jackson-core</artifactId>
8282
</dependency>
8383
<dependency>
84-
<groupId>com.fasterxml.jackson.core</groupId>
85-
<artifactId>jackson-annotations</artifactId>
84+
<groupId>tools.jackson.core</groupId>
85+
<artifactId>jackson-databind</artifactId>
8686
</dependency>
8787
<dependency>
8888
<groupId>org.junit.jupiter</groupId>
@@ -126,4 +126,5 @@
126126
</dependency>
127127
</dependencies>
128128

129+
129130
</project>

spring-cloud-starter-single-step-batch-job/src/main/java/org/springframework/cloud/task/batch/autoconfigure/kafka/KafkaItemWriterAutoConfiguration.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
import org.springframework.kafka.core.DefaultKafkaProducerFactory;
3636
import org.springframework.kafka.core.KafkaTemplate;
3737
import org.springframework.kafka.core.ProducerFactory;
38-
import org.springframework.kafka.support.serializer.JsonSerializer;
38+
import org.springframework.kafka.support.serializer.JacksonJsonSerializer;
3939
import org.springframework.util.Assert;
4040

4141
/**
@@ -87,7 +87,7 @@ public Object convert(Map<String, Object> source) {
8787
ProducerFactory<Object, Map<String, Object>> producerFactory() {
8888
Map<String, Object> configs = new HashMap<>();
8989
configs.putAll(this.kafkaProperties.getProducer().buildProperties());
90-
return new DefaultKafkaProducerFactory<>(configs, null, new JsonSerializer<>());
90+
return new DefaultKafkaProducerFactory<>(configs, null, new JacksonJsonSerializer());
9191
}
9292

9393
private void validateProperties(KafkaItemWriterProperties kafkaItemWriterProperties) {

spring-cloud-starter-single-step-batch-job/src/main/java/org/springframework/cloud/task/batch/autoconfigure/rabbit/AmqpItemReaderAutoConfiguration.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
import java.util.Map;
2020

2121
import org.springframework.amqp.core.AmqpTemplate;
22-
import org.springframework.amqp.support.converter.Jackson2JsonMessageConverter;
22+
import org.springframework.amqp.support.converter.JacksonJsonMessageConverter;
2323
import org.springframework.amqp.support.converter.MessageConverter;
2424
import org.springframework.batch.item.amqp.AmqpItemReader;
2525
import org.springframework.batch.item.amqp.builder.AmqpItemReaderBuilder;
@@ -68,7 +68,7 @@ public AmqpItemReader<Map<String, Object>> amqpItemReader(AmqpTemplate amqpTempl
6868
matchIfMissing = true)
6969
@Bean
7070
public MessageConverter messageConverter() {
71-
return new Jackson2JsonMessageConverter();
71+
return new JacksonJsonMessageConverter();
7272
}
7373

7474
}

spring-cloud-starter-single-step-batch-job/src/main/java/org/springframework/cloud/task/batch/autoconfigure/rabbit/AmqpItemReaderProperties.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
package org.springframework.cloud.task.batch.autoconfigure.rabbit;
1818

19-
import org.springframework.amqp.support.converter.Jackson2JsonMessageConverter;
19+
import org.springframework.amqp.support.converter.JacksonJsonMessageConverter;
2020
import org.springframework.boot.context.properties.ConfigurationProperties;
2121

2222
/**
@@ -34,7 +34,7 @@ public class AmqpItemReaderProperties {
3434
private boolean enabled;
3535

3636
/**
37-
* Establishes whether the {@link Jackson2JsonMessageConverter} is to be used as a
37+
* Establishes whether the {@link JacksonJsonMessageConverter} is to be used as a
3838
* message converter. Defaults to {@code true}.
3939
*/
4040
private boolean jsonConverterEnabled = true;
@@ -56,7 +56,7 @@ public void setEnabled(boolean enabled) {
5656
}
5757

5858
/**
59-
* States whether the {@link Jackson2JsonMessageConverter} is used as a message
59+
* States whether the {@link JacksonJsonMessageConverter} is used as a message
6060
* converter.
6161
* @return true if enabled else false.
6262
*/
@@ -65,7 +65,7 @@ public boolean isJsonConverterEnabled() {
6565
}
6666

6767
/**
68-
* Establishes whether the {@link Jackson2JsonMessageConverter} is to be used as a
68+
* Establishes whether the {@link JacksonJsonMessageConverter} is to be used as a
6969
* message converter.
7070
* @param jsonConverterEnabled true if it is to be enabled else false. Defaults to
7171
* true.

spring-cloud-starter-single-step-batch-job/src/main/java/org/springframework/cloud/task/batch/autoconfigure/rabbit/AmqpItemWriterAutoConfiguration.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
import java.util.Map;
2020

2121
import org.springframework.amqp.core.AmqpTemplate;
22-
import org.springframework.amqp.support.converter.Jackson2JsonMessageConverter;
22+
import org.springframework.amqp.support.converter.JacksonJsonMessageConverter;
2323
import org.springframework.amqp.support.converter.MessageConverter;
2424
import org.springframework.batch.item.amqp.AmqpItemWriter;
2525
import org.springframework.batch.item.amqp.builder.AmqpItemWriterBuilder;
@@ -57,7 +57,7 @@ public AmqpItemWriterProperties amqpItemWriterProperties() {
5757
matchIfMissing = true)
5858
@Bean
5959
public MessageConverter messageConverter() {
60-
return new Jackson2JsonMessageConverter();
60+
return new JacksonJsonMessageConverter();
6161
}
6262

6363
}

spring-cloud-starter-single-step-batch-job/src/main/java/org/springframework/cloud/task/batch/autoconfigure/rabbit/AmqpItemWriterProperties.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
package org.springframework.cloud.task.batch.autoconfigure.rabbit;
1818

19-
import org.springframework.amqp.support.converter.Jackson2JsonMessageConverter;
19+
import org.springframework.amqp.support.converter.JacksonJsonMessageConverter;
2020
import org.springframework.boot.context.properties.ConfigurationProperties;
2121

2222
/**
@@ -32,7 +32,7 @@ public class AmqpItemWriterProperties {
3232
private boolean enabled;
3333

3434
/**
35-
* Establishes whether the {@link Jackson2JsonMessageConverter} is to be used as a
35+
* Establishes whether the {@link JacksonJsonMessageConverter} is to be used as a
3636
* message converter. Defaults to {@code true}.
3737
*/
3838
private boolean jsonConverterEnabled = true;
@@ -55,7 +55,7 @@ public void setEnabled(boolean enabled) {
5555
}
5656

5757
/**
58-
* States whether the {@link Jackson2JsonMessageConverter} is used as a message
58+
* States whether the {@link JacksonJsonMessageConverter} is used as a message
5959
* converter.
6060
* @return true if enabled else false.
6161
*/
@@ -64,7 +64,7 @@ public boolean isJsonConverterEnabled() {
6464
}
6565

6666
/**
67-
* Establishes whether the {@link Jackson2JsonMessageConverter} is to be used as a
67+
* Establishes whether the {@link JacksonJsonMessageConverter} is to be used as a
6868
* message converter.
6969
* @param jsonConverterEnabled true if it is to be enabled else false. Defaults to
7070
* true.

spring-cloud-starter-single-step-batch-job/src/test/java/org/springframework/cloud/task/batch/autoconfigure/rabbit/AmqpItemReaderAutoConfigurationTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
import org.springframework.amqp.rabbit.connection.ConnectionFactory;
3636
import org.springframework.amqp.rabbit.core.RabbitAdmin;
3737
import org.springframework.amqp.rabbit.core.RabbitTemplate;
38-
import org.springframework.amqp.support.converter.Jackson2JsonMessageConverter;
38+
import org.springframework.amqp.support.converter.JacksonJsonMessageConverter;
3939
import org.springframework.batch.core.job.Job;
4040
import org.springframework.batch.core.job.JobExecution;
4141
import org.springframework.batch.core.job.parameters.JobParameters;
@@ -80,7 +80,7 @@ public class AmqpItemReaderAutoConfigurationTests {
8080
void setupTest() {
8181
this.connectionFactory = new CachingConnectionFactory(host, amqpPort);
8282
this.template = new RabbitTemplate(this.connectionFactory);
83-
this.template.setMessageConverter(new Jackson2JsonMessageConverter());
83+
this.template.setMessageConverter(new JacksonJsonMessageConverter());
8484
AmqpAdmin admin = new RabbitAdmin(this.connectionFactory);
8585
admin.declareQueue(new Queue("foo"));
8686

spring-cloud-starter-single-step-batch-job/src/test/java/org/springframework/cloud/task/batch/autoconfigure/rabbit/AmqpItemWriterAutoConfigurationTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
import org.springframework.amqp.rabbit.connection.ConnectionFactory;
3939
import org.springframework.amqp.rabbit.core.RabbitAdmin;
4040
import org.springframework.amqp.rabbit.core.RabbitTemplate;
41-
import org.springframework.amqp.support.converter.Jackson2JsonMessageConverter;
41+
import org.springframework.amqp.support.converter.JacksonJsonMessageConverter;
4242
import org.springframework.batch.core.job.Job;
4343
import org.springframework.batch.core.job.JobExecution;
4444
import org.springframework.batch.core.job.parameters.JobParameters;
@@ -105,7 +105,7 @@ private static void addNameToReaderList(List<Map<String, Object>> itemReaderList
105105
void setupTest() {
106106
this.connectionFactory = new CachingConnectionFactory(host, amqpPort);
107107
this.template = new RabbitTemplate(this.connectionFactory);
108-
this.template.setMessageConverter(new Jackson2JsonMessageConverter());
108+
this.template.setMessageConverter(new JacksonJsonMessageConverter());
109109
AmqpAdmin admin = new RabbitAdmin(this.connectionFactory);
110110
admin.declareQueue(new Queue(QUEUE_NAME));
111111
admin.declareExchange(new TopicExchange(EXCHANGE_NAME));

spring-cloud-task-samples/single-step-batch-job/pom.xml

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -53,16 +53,6 @@
5353
<groupId>org.springframework.boot</groupId>
5454
<artifactId>spring-boot-starter-jdbc</artifactId>
5555
</dependency>
56-
<dependency>
57-
<groupId>com.fasterxml.jackson.core</groupId>
58-
<artifactId>jackson-core</artifactId>
59-
<optional>true</optional>
60-
</dependency>
61-
<dependency>
62-
<groupId>com.fasterxml.jackson.core</groupId>
63-
<artifactId>jackson-databind</artifactId>
64-
<optional>true</optional>
65-
</dependency>
6656
<dependency>
6757
<groupId>com.h2database</groupId>
6858
<artifactId>h2</artifactId>

0 commit comments

Comments
 (0)