Merge pull request #100 from jmsche/fix/php-8.4-deprecation

Fix PHP 8.4 deprecation

Author: freekmurze

src/DropboxAdapter.php

@@ -25,7 +25,7 @@
 use Spatie\Dropbox\Client;
 use Spatie\Dropbox\Exceptions\BadRequest;
 
-class DropboxAdapter implements FilesystemAdapter, ChecksumProvider
+class DropboxAdapter implements ChecksumProvider, FilesystemAdapter
 {
     protected Client $client;
 
@@ -36,11 +36,11 @@ class DropboxAdapter implements FilesystemAdapter, ChecksumProvider
     public function __construct(
         Client $client,
         string $prefix = '',
-        MimeTypeDetector $mimeTypeDetector = null
+        ?MimeTypeDetector $mimeTypeDetector = null
     ) {
         $this->client = $client;
         $this->prefixer = new PathPrefixer($prefix);
-        $this->mimeTypeDetector = $mimeTypeDetector ?: new FinfoMimeTypeDetector();
+        $this->mimeTypeDetector = $mimeTypeDetector ?: new FinfoMimeTypeDetector;
     }
 
     public function getClient(): Client

tests/DropboxAdapterTest.php

@@ -31,7 +31,7 @@
         '.tag' => 'file',
     ]);
 
-    $this->dropboxAdapter->write('something', 'contents', new Config());
+    $this->dropboxAdapter->write('something', 'contents', new Config);
     $this->addToAssertionCount(1);
 });
 
@@ -42,7 +42,7 @@
         '.tag' => 'file',
     ]);
 
-    $this->dropboxAdapter->writeStream('something', tmpfile(), new Config());
+    $this->dropboxAdapter->writeStream('something', tmpfile(), new Config);
     $this->addToAssertionCount(1);
 });
 
@@ -130,9 +130,9 @@
         'path_display' => '/prefix/pass/please',
     ]);
 
-    $this->dropboxAdapter->createDirectory('fail/please', new Config());
+    $this->dropboxAdapter->createDirectory('fail/please', new Config);
 
-    $this->dropboxAdapter->createDirectory('pass/please', new Config());
+    $this->dropboxAdapter->createDirectory('pass/please', new Config);
     $this->addToAssertionCount(1);
 })->throws(UnableToCreateDirectory::class);
 
@@ -168,14 +168,14 @@
 it('can move a file', function () {
     $this->client->move(Argument::type('string'), Argument::type('string'))->willReturn(['.tag' => 'file', 'path' => 'something']);
 
-    $this->dropboxAdapter->move('something', 'something', new Config());
+    $this->dropboxAdapter->move('something', 'something', new Config);
     $this->addToAssertionCount(1);
 });
 
 it('can handle a failing move', function () {
     $this->client->move('/prefix/something', '/prefix/something')->willThrow(new BadRequest(new Response(409)));
 
-    $this->dropboxAdapter->move('something', 'something', new Config());
+    $this->dropboxAdapter->move('something', 'something', new Config);
 })->throws(UnableToMoveFile::class);
 
 it('can copy', function () {
@@ -184,14 +184,14 @@
         Argument::type('string')
     )->willReturn(['.tag' => 'file', 'path' => 'something']);
 
-    $this->dropboxAdapter->copy('something', 'something', new Config());
+    $this->dropboxAdapter->copy('something', 'something', new Config);
     $this->addToAssertionCount(1);
 });
 
 it('can handle a failing copy', function () {
     $this->client->copy(Argument::any(), Argument::any())->willThrow(new BadRequest(new Response(409)));
 
-    $this->dropboxAdapter->copy('something', 'something', new Config());
+    $this->dropboxAdapter->copy('something', 'something', new Config);
 })->throws(UnableToCopyFile::class);
 
 test('getClient')