Skip to content

Commit 07cbe15

Browse files
Not-Sarthakdarrachequesne
authored andcommitted
fix(eio): add @types/ws as dependency (#5458)
Since engine.io@6.6.5, the generated .d.ts files import types from "ws" (WebSocket, PerMessageDeflateOptions), but @types/ws was not declared as a dependency. This causes TypeScript compilation errors for consumers who do not have @types/ws installed. This follows the existing pattern where @types/cors and @types/node are already listed as dependencies. Related: #5437
1 parent 44ed73f commit 07cbe15

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

package-lock.json

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/engine.io/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
"dependencies": {
3434
"@types/cors": "^2.8.12",
3535
"@types/node": ">=10.0.0",
36+
"@types/ws": "^8.5.12",
3637
"accepts": "~1.3.4",
3738
"base64id": "2.0.0",
3839
"cookie": "~0.7.2",

0 commit comments

Comments
 (0)