sgame: resend configstrings that could be wrong

...due to a map change during the client downloading something. This is
a temporary workaround until clients have
DaemonEngine/Daemon#1954.

Author: slipher

src/sgame/sg_client.cpp

@@ -1265,6 +1265,28 @@ const char *ClientBotConnect( int clientNum, bool firstTime )
 	return nullptr;
 }
 
+// Resend configstrings that could be affected by https://github.com/Unvanquished/Unvanquished/issues/1102.
+// TODO(0.57): remove since with the new version we have well-behaved clients.
+static void ResendPossiblyWrongConfigstrings( int clientNum )
+{
+	for ( int cs = CS_PLAYERS + level.maxclients; cs--; )
+	{
+		char configstring[ 1022 ];
+		trap_GetConfigstring( cs, configstring, sizeof( configstring ) );
+		std::string command = Str::Format( "cs %d %s", cs, Cmd::Escape( configstring ) );
+		if ( command.size() > 1022 )
+		{
+			// don't want to re-implement all of the bcs0 bcs1 bcs2 junk for this band-aid
+			Log::Warn( "Disabling configstring update workaround for client %d string %d due to length",
+			           clientNum, cs );
+		}
+		else
+		{
+			trap_SendServerCommand( clientNum, command.c_str() );
+		}
+	}
+}
+
 /*
 ===========
 ClientBegin
@@ -1322,6 +1344,8 @@ void ClientBegin( int clientNum )
 	// locate ent at a spawn point
 	ClientSpawn( ent, nullptr, nullptr, nullptr );
 
+	ResendPossiblyWrongConfigstrings( clientNum );
+
 	trap_SendServerCommand( -1, va( "print_tr %s %s", QQ( N_("$1$^* entered the game") ), Quote( client->pers.netname ) ) );
 
 	std::string startMsg = g_mapStartupMessage.Get();

src/shared/bg_public.h

@@ -242,9 +242,7 @@ enum team_t
 // CS_SERVERINFO and CS_SYSTEMINFO are defined in q_shared.h
 enum
 {
-  CS_MUSIC = RESERVED_CONFIGSTRINGS,
-  CS_MESSAGE, // from the map worldspawn's message field
-  CS_MOTD, // g_motd string for server message of the day
+  CS_MOTD = RESERVED_CONFIGSTRINGS, // g_motd string for server message of the day
   CS_WARMUP, // server time when the match will be restarted
 
   CS_VOTE_TIME, // Vote stuff each needs NUM_TEAMS slots
@@ -260,15 +258,21 @@ enum
   CS_SHADERSTATE,
   CS_CLIENTS_READY,
 
+  CS_PLAYERS,
+
+  // Stuff below this normally never changes after the match starts
+
+  CS_MUSIC = CS_PLAYERS + MAX_CLIENTS,
+  CS_MESSAGE, // from the map worldspawn's message field
+
   CS_MODELS,
   CS_SOUNDS = CS_MODELS + MAX_MODELS,
   CS_SHADERS = CS_SOUNDS + MAX_SOUNDS,
   CS_GRADING_TEXTURES = CS_SHADERS + MAX_GAME_SHADERS,
   CS_REVERB_EFFECTS = CS_GRADING_TEXTURES + MAX_GRADING_TEXTURES,
   CS_PARTICLE_SYSTEMS = CS_REVERB_EFFECTS + MAX_REVERB_EFFECTS,
 
-  CS_PLAYERS = CS_PARTICLE_SYSTEMS + MAX_GAME_PARTICLE_SYSTEMS,
-  CS_LOCATIONS = CS_PLAYERS + MAX_CLIENTS,
+  CS_LOCATIONS = CS_PARTICLE_SYSTEMS + MAX_GAME_PARTICLE_SYSTEMS,
   CS_MAX = CS_LOCATIONS + MAX_LOCATIONS
 };