address bugbot comments

Author: icecrasher321

apps/sim/lib/copilot/tools/server/workflow/edit-workflow/validation.ts

@@ -352,17 +352,16 @@ export function validateValueForSubBlockType(
     case 'short-input':
     case 'long-input':
     case 'combobox': {
-      let stringValue: string
-      if (typeof value !== 'string' && typeof value !== 'number') {
-        stringValue = String(value)
-      } else {
-        stringValue = typeof value === 'number' ? String(value) : value
-      }
-
       const usesProviderCatalog =
         fieldName === 'model' && subBlockConfig.options === getModelOptions
 
       if (usesProviderCatalog) {
+        const stringValue =
+          typeof value === 'string'
+            ? value
+            : typeof value === 'number'
+              ? String(value)
+              : String(value)
         const trimmed = stringValue.trim()
         if (trimmed !== '' && !isKnownModelId(trimmed)) {
           const suggestions = suggestModelIdsForUnknownModel(trimmed)
@@ -382,7 +381,10 @@ export function validateValueForSubBlockType(
         return { valid: true, value: trimmed }
       }
 
-      return { valid: true, value: typeof value === 'string' ? value : stringValue }
+      if (typeof value !== 'string' && typeof value !== 'number') {
+        return { valid: true, value: String(value) }
+      }
+      return { valid: true, value }
     }
 
     // Selector types - allow strings (IDs) or arrays of strings

apps/sim/providers/models.ts

@@ -2711,7 +2711,7 @@ export function getProviderModels(providerId: string): string[] {
 
 export const DYNAMIC_MODEL_PROVIDERS = ['ollama', 'vllm', 'openrouter', 'fireworks'] as const
 
-export function getAllStaticModelIds(): string[] {
+function getAllStaticModelIds(): string[] {
   const ids: string[] = []
   for (const [providerId, provider] of Object.entries(PROVIDER_DEFINITIONS)) {
     if ((DYNAMIC_MODEL_PROVIDERS as readonly string[]).includes(providerId)) continue
@@ -2737,7 +2737,7 @@ export function isKnownModelId(modelId: string): boolean {
   return false
 }
 
-export function getRecommendedModels(): string[] {
+function getRecommendedModels(): string[] {
   const models: string[] = []
   for (const [providerId, provider] of Object.entries(PROVIDER_DEFINITIONS)) {
     if ((DYNAMIC_MODEL_PROVIDERS as readonly string[]).includes(providerId)) continue