Add test cases

Author: smoelius

tests/testsuite/rustup.rs

@@ -311,39 +311,84 @@ custom toolchain rustc running
 /// Performs a `cargo install` with a non-default toolchain in a simulated
 /// rustup environment. The purpose is to verify the warning that is emitted.
 #[cargo_test]
-fn cargo_install_with_non_default_toolchain() {
+fn cargo_install_with_toolchain_source_unset() {
+    cargo_install_with_toolchain_source(None, false);
+}
+
+#[cargo_test]
+fn cargo_install_with_toolchain_source_default() {
+    cargo_install_with_toolchain_source(Some("default"), false);
+}
+
+#[cargo_test]
+fn cargo_install_with_toolchain_source_cli() {
+    cargo_install_with_toolchain_source(Some("cli"), false);
+}
+
+#[cargo_test]
+fn cargo_install_with_toolchain_source_env() {
+    cargo_install_with_toolchain_source(Some("env"), true);
+}
+
+#[cargo_test]
+fn cargo_install_with_toolchain_source_path_override() {
+    cargo_install_with_toolchain_source(Some("path-override"), true);
+}
+
+#[cargo_test]
+fn cargo_install_with_toolchain_source_toolchain_file() {
+    cargo_install_with_toolchain_source(Some("toolchain-file"), true);
+}
+
+#[cargo_test]
+fn cargo_install_with_toolchain_source_invalid() {
+    cargo_install_with_toolchain_source(Some("invalid"), false);
+}
+
+fn cargo_install_with_toolchain_source(source: Option<&str>, should_warn: bool) {
+    let mut builder = RustupEnvironmentBuilder::new();
+    builder.call_cargo_under_test();
+    builder.env("RUSTUP_TOOLCHAIN", "test-toolchain");
+    if let Some(source) = source {
+        builder.env("RUSTUP_TOOLCHAIN_SOURCE", source);
+    };
     let RustupEnvironment {
         cargo_bin,
         rustup_home: _,
         cargo_toolchain_exe: _,
-    } = RustupEnvironmentBuilder::new()
-        .call_cargo_under_test()
-        .env("RUSTUP_TOOLCHAIN_SOURCE", "env")
-        .env("RUSTUP_TOOLCHAIN", "test-toolchain")
-        .build();
+    } = builder.build();
 
     pkg("foo", "0.0.1");
 
     let mut p = process(cargo_bin.join("cargo"));
     p.arg_line("install foo");
-    execs()
-        .with_process_builder(p)
-        .with_stderr_data(str![[r#"
-`[..]/cargo[EXE]` proxy running
+    let maybe_warning = if should_warn {
+        format!(
+            r#"[WARNING] using non-default toolchain `test-toolchain` overridden by {}
+  |
+  = [HELP] use `cargo +stable install` if you meant to use the stable toolchain.
+"#,
+            source.unwrap()
+        )
+    } else {
+        String::new()
+    };
+    let stderr = format!(
+        r#"`[..]/cargo[EXE]` proxy running
 [UPDATING] `dummy-registry` index
 [DOWNLOADING] crates ...
 [DOWNLOADED] foo v0.0.1 (registry `dummy-registry`)
 [INSTALLING] foo v0.0.1
-[WARNING] using non-default toolchain `test-toolchain` overridden by env
-  |
-  = [HELP] use `cargo +stable install` if you meant to use the stable toolchain.
-[COMPILING] foo v0.0.1
+{maybe_warning}[COMPILING] foo v0.0.1
 [FINISHED] `release` profile [optimized] target(s) in [ELAPSED]s
 [INSTALLING] [ROOT]/home/.cargo/bin/foo[EXE]
 [INSTALLED] package `foo v0.0.1` (executable `foo[EXE]`)
 [WARNING] be sure to add `[ROOT]/home/.cargo/bin` to your PATH to be able to run the installed binaries
-
-"#]])
+"#
+    );
+    execs()
+        .with_process_builder(p)
+        .with_stderr_data(stderr)
         .run();
     assert_has_installed_exe(cargo_home(), "foo");
 }