Implement 11036 cargo changes

Author: smoelius

src/cargo/ops/cargo_install.rs

@@ -1,7 +1,7 @@
 use std::collections::{BTreeMap, BTreeSet, HashMap, HashSet};
 use std::path::{Path, PathBuf};
 use std::sync::Arc;
-use std::{env, fs};
+use std::{env, fmt, fs};
 
 use crate::core::compiler::{CompileKind, DefaultExecutor, Executor, UnitOutput};
 use crate::core::{Dependency, Edition, Package, PackageId, SourceId, Target, Workspace};
@@ -14,12 +14,14 @@ use crate::util::errors::CargoResult;
 use crate::util::{Filesystem, GlobalContext, Rustc};
 use crate::{drop_println, ops};
 
+use annotate_snippets::Level;
 use anyhow::{Context as _, bail};
 use cargo_util::paths;
 use cargo_util_schemas::core::PartialVersion;
 use itertools::Itertools;
 use semver::VersionReq;
 use tempfile::Builder as TempFileBuilder;
+use tracing::debug;
 
 struct Transaction {
     bins: Vec<PathBuf>,
@@ -39,6 +41,42 @@ impl Drop for Transaction {
     }
 }
 
+enum RustupToolchainSource {
+    Default,
+    Environment,
+    CommandLine,
+    OverrideDB,
+    ToolchainFile,
+    Other(String),
+}
+
+#[allow(dead_code)]
+impl RustupToolchainSource {
+    fn is_implicit_override(&self) -> Option<bool> {
+        match self {
+            Self::Default => Some(false),
+            Self::Environment => Some(true),
+            Self::CommandLine => Some(false),
+            Self::OverrideDB => Some(true),
+            Self::ToolchainFile => Some(true),
+            Self::Other(_) => None,
+        }
+    }
+}
+
+impl fmt::Display for RustupToolchainSource {
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+        f.write_str(match self {
+            Self::Default => "default",
+            Self::Environment => "environment variable",
+            Self::CommandLine => "command line",
+            Self::OverrideDB => "rustup directory override",
+            Self::ToolchainFile => "rustup toolchain file",
+            Self::Other(other) => other,
+        })
+    }
+}
+
 struct InstallablePackage<'gctx> {
     gctx: &'gctx GlobalContext,
     opts: ops::CompileOptions,
@@ -316,6 +354,31 @@ impl<'gctx> InstallablePackage<'gctx> {
     fn install_one(mut self, dry_run: bool) -> CargoResult<bool> {
         self.gctx.shell().status("Installing", &self.pkg)?;
 
+        if let Some(source) = get_rustup_toolchain_source()
+            && source.is_implicit_override().unwrap_or_else(|| {
+                debug!("ignoring unrecognized rustup toolchain source `{source}`");
+                false
+            })
+        {
+            #[expect(clippy::disallowed_methods, reason = "consistency with rustup")]
+            let maybe_toolchain = env::var("RUSTUP_TOOLCHAIN")
+                .ok()
+                .map(|toolchain| format!(" with `{toolchain}`"))
+                .unwrap_or_default();
+            let report = &[Level::WARNING
+                .secondary_title(format!(
+                    "default toolchain implicitly overridden{maybe_toolchain} by {source}"
+                ))
+                .element(Level::HELP.message(format!(
+                    "use `cargo +stable install` if you meant to use the stable toolchain"
+                )))
+                .element(Level::NOTE.message(format!(
+                    "rustup selects the toolchain based on the parent environment and not the \
+                     environment of the package being installed"
+                )))];
+            self.gctx.shell().print_report(report, false)?;
+        }
+
         // Normalize to absolute path for consistency throughout.
         // See: https://github.com/rust-lang/cargo/issues/16023
         let dst = self.root.join("bin").into_path_unlocked();
@@ -611,6 +674,20 @@ impl<'gctx> InstallablePackage<'gctx> {
     }
 }
 
+fn get_rustup_toolchain_source() -> Option<RustupToolchainSource> {
+    #[expect(clippy::disallowed_methods, reason = "consistency with rustup")]
+    let source = std::env::var("RUSTUP_TOOLCHAIN_SOURCE").ok()?;
+    let source = match source.as_str() {
+        "default" => RustupToolchainSource::Default,
+        "env" => RustupToolchainSource::Environment,
+        "cli" => RustupToolchainSource::CommandLine,
+        "path-override" => RustupToolchainSource::OverrideDB,
+        "toolchain-file" => RustupToolchainSource::ToolchainFile,
+        other => RustupToolchainSource::Other(other.to_owned()),
+    };
+    Some(source)
+}
+
 fn make_warning_about_missing_features(binaries: &[&Target]) -> String {
     let max_targets_listed = 7;
     let target_features_message = binaries

tests/testsuite/rustup.rs

@@ -59,6 +59,13 @@ fn real_rustc_wrapper(bin_dir: &Path, message: &str) -> PathBuf {
     // The toolchain rustc needs to call the real rustc. In order to do that,
     // it needs to restore or clear the RUSTUP environment variables so that
     // if rustup is installed, it will call the correct rustc.
+    let rustup_toolchain_source_setup = match std::env::var_os("RUSTUP_TOOLCHAIN_SOURCE") {
+        Some(t) => format!(
+            ".env(\"RUSTUP_TOOLCHAIN_SOURCE\", \"{}\")",
+            t.into_string().unwrap()
+        ),
+        None => String::new(),
+    };
     let rustup_toolchain_setup = match std::env::var_os("RUSTUP_TOOLCHAIN") {
         Some(t) => format!(
             ".env(\"RUSTUP_TOOLCHAIN\", \"{}\")",
@@ -82,6 +89,7 @@ fn real_rustc_wrapper(bin_dir: &Path, message: &str) -> PathBuf {
                 eprintln!("{message}");
                 let r = std::process::Command::new(env!("CARGO_RUSTUP_TEST_real_rustc"))
                     .args(std::env::args_os().skip(1))
+                    {rustup_toolchain_source_setup}
                     {rustup_toolchain_setup}
                     {rustup_home_setup}
                     .status();
@@ -390,6 +398,10 @@ fn cargo_install_with_toolchain_source_env() {
 [DOWNLOADING] crates ...
 [DOWNLOADED] foo v0.0.1 (registry `dummy-registry`)
 [INSTALLING] foo v0.0.1
+[WARNING] default toolchain implicitly overridden with `test-toolchain` by environment variable
+  |
+  = [HELP] use `cargo +stable install` if you meant to use the stable toolchain
+  = [NOTE] rustup selects the toolchain based on the parent environment and not the environment of the package being installed
 [COMPILING] foo v0.0.1
 [FINISHED] `release` profile [optimized] target(s) in [ELAPSED]s
 [INSTALLING] [ROOT]/home/.cargo/bin/foo[EXE]
@@ -410,6 +422,10 @@ fn cargo_install_with_toolchain_source_path_override() {
 [DOWNLOADING] crates ...
 [DOWNLOADED] foo v0.0.1 (registry `dummy-registry`)
 [INSTALLING] foo v0.0.1
+[WARNING] default toolchain implicitly overridden with `test-toolchain` by rustup directory override
+  |
+  = [HELP] use `cargo +stable install` if you meant to use the stable toolchain
+  = [NOTE] rustup selects the toolchain based on the parent environment and not the environment of the package being installed
 [COMPILING] foo v0.0.1
 [FINISHED] `release` profile [optimized] target(s) in [ELAPSED]s
 [INSTALLING] [ROOT]/home/.cargo/bin/foo[EXE]
@@ -430,6 +446,10 @@ fn cargo_install_with_toolchain_source_toolchain_file() {
 [DOWNLOADING] crates ...
 [DOWNLOADED] foo v0.0.1 (registry `dummy-registry`)
 [INSTALLING] foo v0.0.1
+[WARNING] default toolchain implicitly overridden with `test-toolchain` by rustup toolchain file
+  |
+  = [HELP] use `cargo +stable install` if you meant to use the stable toolchain
+  = [NOTE] rustup selects the toolchain based on the parent environment and not the environment of the package being installed
 [COMPILING] foo v0.0.1
 [FINISHED] `release` profile [optimized] target(s) in [ELAPSED]s
 [INSTALLING] [ROOT]/home/.cargo/bin/foo[EXE]