prevent another null pointer exception

rgl · rgl · commit a9db6ec6a83e · 2024-07-12T20:26:16.000+01:00
diff --git a/update/windows-update.ps1 b/update/windows-update.ps1
@@ -200,7 +200,7 @@ for ($i = 0; $i -lt $searchResult.Updates.Count; ++$i) {
     $properties = $update `
         | Get-Member $expectedProperties `
         | Select-Object -ExpandProperty Name
-    if (Compare-Object $expectedProperties $properties) {
+    if (!$properties -or (Compare-Object $expectedProperties $properties)) {
         throw "the windows update api returned a invalid update object. see https://github.com/rgl/packer-plugin-windows-update/issues/144."
     }
 

Original file line number	Diff line number	Diff line change
`@@ -200,7 +200,7 @@ for ($i = 0; $i -lt $searchResult.Updates.Count; ++$i) {`
`200`	`200`	$properties = $update `
`201`	`201`	\| Get-Member $expectedProperties `
`202`	`202`	`\| Select-Object -ExpandProperty Name`
`203`		`- if (Compare-Object $expectedProperties $properties) {`
	`203`	`+ if (!$properties -or (Compare-Object $expectedProperties $properties)) {`
`204`	`204`	`throw "the windows update api returned a invalid update object. see https://github.com/rgl/packer-plugin-windows-update/issues/144."`
`205`	`205`	`}`
`206`	`206`